From 624c178554eb87fae6ad1b942fed3c6b413149ac Mon Sep 17 00:00:00 2001
From: jewelcodes <omarmelghoul01@gmail.com>
Date: Fri, 29 Nov 2024 23:22:57 -0500
Subject: [PATCH] servers: remove unnecessary locking in server response
 handling

---
 src/servers/syscalls.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/servers/syscalls.c b/src/servers/syscalls.c
index 54dd3be0..53821fb8 100644
--- a/src/servers/syscalls.c
+++ b/src/servers/syscalls.c
@@ -34,13 +34,12 @@ void handleSyscallResponse(const SyscallHeader *hdr) {
     }
 
     // default action is to unblock the thread
-    schedLock();
     Process *p = getProcess(req->thread->pid);
     req->ret = hdr->header.status;
     req->external = false;
     req->unblock = true;
     req->thread->time = schedTimeslice(req->thread, req->thread->priority);
-    req->thread->status = THREAD_QUEUED;
+    //req->thread->status = THREAD_QUEUED;
 
     // some syscalls will require special handling
     ssize_t status;
@@ -99,7 +98,6 @@ void handleSyscallResponse(const SyscallHeader *hdr) {
             req->queued = true;
             req->next = NULL;
             req->retry = true;
-            schedRelease();
             syscallEnqueue(req);
             break;
         } else if(status < 0) break;  // here an actual error happened
@@ -125,7 +123,6 @@ void handleSyscallResponse(const SyscallHeader *hdr) {
             req->queued = true;
             req->next = NULL;
             req->retry = true;
-            schedRelease();
             syscallEnqueue(req);
             break;
         } else if(status < 0) break;  // here an actual error happened
@@ -201,6 +198,8 @@ void handleSyscallResponse(const SyscallHeader *hdr) {
     case COMMAND_EXEC:
         if(hdr->header.status) break;
 
+        schedLock();
+
         int execStatus = execveHandle((ExecCommand *) hdr);
 
         if(!execStatus) {
@@ -230,5 +229,5 @@ void handleSyscallResponse(const SyscallHeader *hdr) {
     }
 
     platformSetContextStatus(req->thread->context, req->ret);
-    schedRelease();
+    req->thread->status = THREAD_QUEUED;
 }