Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit, Market: Refactor credit cards details to use data from conf/commerce #146

Open
erikrakuscek opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
launch refactor / internal an internal improvement

Comments

@erikrakuscek
Copy link
Contributor

Work on this issue once enh/120/new-buy-drawer branch is merged to main.

Move all details about credit cards from src/content/cards to conf/commerce. This way we will get rid of duplicated data and have all credit card data in one place.

Refactor the code on credit site to use this data and stick to the new naming of product tree nodes.
Product families: black, elite, founder, sovereign
Products: 24k gold elite card, sterling silver elite card, etc.

@erikrakuscek erikrakuscek added the refactor / internal an internal improvement label Apr 8, 2024
@erikrakuscek erikrakuscek self-assigned this Apr 8, 2024
@zeekay zeekay added this to the MVP milestone May 2, 2024
@artemis-prime artemis-prime self-assigned this May 31, 2024
@artemis-prime
Copy link
Contributor

Please confer w me on this since there are a few nuances @zeekay

@artemis-prime
Copy link
Contributor

We don't need this for mvp. It's strictly a internal thing

@artemis-prime artemis-prime removed this from the MVP milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launch refactor / internal an internal improvement
Projects
Status: No status
Development

No branches or pull requests

3 participants