Can't compile the .exe with visual studio 9.0

[MariusLTU]

Hey,
I'm trying to generate bhtsne.exe by following your instructions, but I keep getting this message on the cmd:
sptree.cpp
sptree.cpp(111): error C3861: 'fmax': identifier not found
sptree.cpp(335): error C3861: 'fmax': identifier not found
NMAKE: fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\amd64\cl.exe"': return code '0x2'

Any idea how to fix it?

[ly63513]

+1

[lvdmaaten]

I don't have Visual Studio (or a Windows machine), so I cannot reproduce the issue easily. Can you try and add the following line here and let me know if that resolves the issue?

#include <algorithm>

[MariusLTU]

Thanks for your answer !
Unfortunately I did it and it still doesn't work.

[lvdmaaten]

Oh, sorry! In addition to the change you just made, can you do a global replace of fmax by std::max (there are two occurrences as far as I can tell)?

[MariusLTU]

I got new errors for sptree.cpp(366):

error C2780: expects 3 arguments - 2 provided
see declaration of 'std::max'

error C2782: template parameter '_Ty' is ambiguous
see declaration of 'std::max'
could be 'unsigned int"
or 'int'

[lvdmaaten]

Ah! Can you also change the int here into unsigned int?

If that is insufficient, you could try explicitly templating the std::max call: depth = std::max<unsigned int>(depth, children[i]->getDepth());

[MariusLTU]

Sorry for the late response !
the unsigned int looks like it solved the problem, the executable was created in the windows folder.
But when I open it, nothing happens...

[lvdmaaten]

Are you calling the executable through one of the (Matlab, Python, R) wrappers? These wrappers dump a little data file that the executable consumes. Without the data file, the executable will presumably terminate immediately.

[MariusLTU]

I tried to run it with spyder but it could not compile it:

"TypeError: compile() expected string without null bytes"