Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose the hooks upstream #3

Open
s0undt3ch opened this issue Aug 10, 2017 · 2 comments
Open

Propose the hooks upstream #3

s0undt3ch opened this issue Aug 10, 2017 · 2 comments

Comments

@s0undt3ch
Copy link

Has an attempt to add in the required hooks made to the upstream marshmallow project?

The reason I ask this is because if one tries to install a marshmallow plugin, say, marshmallow-jsonschema, it has marshmallow listed as its dependency and will pull that in when installing.
We're then left with an unpredictable situation on which marshmallow library will python import.
If we uninstall it afterward, we end up with something like:

pkg_resources.DistributionNotFound: The 'marshmallow>=2.9.0' distribution was not found and is required by marshmallow-jsonschema
@rafales
Copy link

rafales commented Aug 13, 2017

I believe this is already done: marshmallow-code/marshmallow#629

@s0undt3ch
Copy link
Author

Thanks, following the issue upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants