Refactoring : Confirmations controller - useless if redirect_url condition

[newfylox]

Version: 1.2.2

in this section

devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb

Lines 29 to 33 in eeed642

	if redirect_url
	redirect_to DeviseTokenAuth::Url.generate(redirect_url, account_confirmation_success: false)
	else
	raise ActionController::RoutingError, 'Not Found'
	end

I was wondering why we are checking if redirect_url because it's necessary of having DeviseTokenAuth.default_confirm_success_url or params[:redirect_url] set.

In other words, imagine having this method returning nil

devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb

Lines 82 to 87 in eeed642

	def redirect_url
	params.fetch(
	:redirect_url,
	DeviseTokenAuth.default_confirm_success_url
	)
	end

It means that the sign_up flow would failed in this section

devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb

Lines 22 to 25 in eeed642

	redirect_to_link = signed_in_resource.build_auth_url(redirect_url, redirect_headers)
	else
	redirect_to_link = DeviseTokenAuth::Url.generate(redirect_url, redirect_header_options)
	end

and throw an exception of type ArgumentError saying bad argument (expected URI object or URI string).

Maybe I missed something?

[newfylox]

Also, it could be nice to say if email is already confirmed. I know it's possible to get the answer by calling this:

@resource.errors.of_kind? :email, :already_confirmed

So it would be nice to specify if account_confirmation_success AND something like already_confirmed in redirect_header_options so that we know if it's because the link is expired or because the email is already confirmed, giving us the chance to show a better message on frontend. There can also have something like link_expired param to tell if it's because the link is expired.