Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Playwright and add tests #37

Open
lyqht opened this issue Oct 10, 2022 · 5 comments
Open

Setup Playwright and add tests #37

lyqht opened this issue Oct 10, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@lyqht
Copy link
Owner

lyqht commented Oct 10, 2022

Description

Seeing how Playwright now has testing library like APIs, and that it is a E2E testing framework, I'm keen to try it out on Octokit-lite now that the project is getting bigger in scale.

Scope

For a start, the tests need to cover login flow (unable to navigate to microapps if not logged in) and navigating to Unfork + its history page when logged in.

Notes

I have not worked with Playwright before, so I cannot offer you help on problems related to the library. I do foresee that there may be complexity in setting this up because of how every page is reliant on the auth state/server side props.

@lyqht lyqht added enhancement New feature or request hacktoberfest labels Oct 10, 2022
@boredcity
Copy link

I have very little experience with Playwright, but I'd be happy to try working on this. Could you assign me to the issue, please?

@lyqht
Copy link
Owner Author

lyqht commented Oct 14, 2022

Sure thing! Thanks for your interest.

@lyqht
Copy link
Owner Author

lyqht commented Oct 25, 2022

Hey there! How is it going @boredcity ?

@boredcity
Copy link

So sorry, it's 18-hour long work days for me currently and I don't really know when things will stabilize and I get a chance to work on anything else.

I think it would make sense to un- or re-assign the task :(

@lyqht
Copy link
Owner Author

lyqht commented Oct 27, 2022

I see, @boredcity no worries! I'll unassihn you for now but if next time the issue is still open and u wanna work on it, let me know 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants