-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocop-git doesn't support per cop Excludes #30
Comments
I've added a PR #33 to deal with it. |
I need this merged! |
Yeah, me too! |
jaynetics
added a commit
to jaynetics/rubocop-git2
that referenced
this issue
Mar 24, 2023
if anyone is still using this, i've release a forked gem, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adding the following to .rubocop.yml works when running
rubocop
, however this has no effect when runningrubocop-git
.It looks to me (correct me if I'm wrong)
rubocop-git
doesn't check if a file should be included on a per cop level, it only respects theAllCops
Exclude
value.Given the current implementation of only checking exclusions and then passing the source to all cops (https://github.com/m4i/rubocop-git/blob/master/lib/rubocop/git/style_guide.rb#L15-L16) - I'm not sure how to easily support these per cop Excludes without completely rethinking how the cops are run - has anyone any thoughts?
The text was updated successfully, but these errors were encountered: