-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocop-git exits with status 1 with disabled cops #39
Comments
We should exit 1, that means error, only when the violations are valid. For valid we mean all the validations that have at least one offence that is not disabled. This will fix this issue: m4i#39
This PR will fix the issue: #47 You can install the gem pointing to the fixed branch in the meantime that it is not merged with master: Remember to add the github source on the top of the gem file:
|
if anyone is still using this, i've release a forked gem, |
I have
rubocop-git
in my CI build process and it's breaking despite the lack of offenses. The output and return value forrubocop-git
looks likeTo debug this code, I printed out the
violations
variable after https://github.com/m4i/rubocop-git/blob/master/lib/rubocop/git/runner.rb#L13This points to a violation for a disabled cop causing the failure. The code at the location specified in the violation is
spec/models/web_monitor/processes_count_spec.rb:28:48
, which is shown below.The text was updated successfully, but these errors were encountered: