Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item runs should log as INFO as they did in Outset Python #49

Open
jazzace opened this issue Mar 6, 2024 · 5 comments
Open

Item runs should log as INFO as they did in Outset Python #49

jazzace opened this issue Mar 6, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jazzace
Copy link

jazzace commented Mar 6, 2024

Describe the bug
In Outset Python, when an item was run (e.g., a script in login-once), the logs would show a line like:
2024-01-01 00:00:03 AM - INFO: Processing /usr/local/outset/login-every/login_script.sh

In this rewrite of Outset, this has been assigned as a DEBUG entry in the logs:
2024-01-01 00:00:04 DEBUG: Processing script /usr/local/outset/login-every/login_script.sh

Ideally, the behaviour in this implementation of Outset should match the previous behaviour.

To Reproduce

  1. Place a script in the login-once or login-every folder within /usr/local/outset/, set to executable by all users.
  2. Log in to an account so that Outset runs the item placed in the folder.
  3. Examine the logs (/usr/local/outset/logs/outset.log in this version of Outset, /Users//Library/Logs/outset.log in Outset Python).

Expected behaviour
That the output should be the same or similar between this version of Outset and Outset Python.

Actual Behaviour
Outset Python shows a line like:
2024-01-01 00:00:03 AM - INFO: Processing /usr/local/outset/login-every/login_script.sh
This version of Outset only shows this information if verbose_logging is turned on in its preferences.

System Details:

  • OS: macOS 13.6.4, 17.4RC
  • Architecture: Intel and Apple Silicon M1 respectively
  • Version: 4.1.1.21918
@bartreardon bartreardon self-assigned this Mar 27, 2024
@bartreardon bartreardon added the enhancement New feature or request label Mar 27, 2024
bartreardon added a commit that referenced this issue Mar 27, 2024
"Processing" type messages are sent as info instead of debug.
@bartreardon
Copy link
Contributor

how does the change in commit 1c38f94 work with #44 where we now output everything to the log file regardless if debug s on or not?

I'm inclined to revert that change and selectively make .debug type log events to .info instead.

@jazzace
Copy link
Author

jazzace commented Mar 27, 2024

Yes, the logs do fix the issue I raised, but as you suggested, I can only get verbose logs now. It would be good if you reverted to the previous behaviour now that Info items are the same as in Outset Python.

@bartreardon
Copy link
Contributor

yeah, I agree - regarding the level of info to debug, is there anything else currently marked as debug that you think should be in info?

@jazzace
Copy link
Author

jazzace commented Mar 27, 2024

I don't think so. I was used to what the Python version gave me.

@bartreardon
Copy link
Contributor

this one ok to close?
If there's any additional stuff you want being logged, LMK and we can chuck it into the 4.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants