-
-
Notifications
You must be signed in to change notification settings - Fork 1
Watch nightly-bench for ten nights after the loop-gate fix #6024
Copy link
Copy link
Open
Labels
P3Later — low urgency, backlogLater — low urgency, backlogarea:benchbench/ — SWE-bench & Arena harnessbench/ — SWE-bench & Arena harnessarea:ciGitHub Actions, release pipeline, packagingGitHub Actions, release pipeline, packagingpain:accuracyWrong output, wrong rendering, wrong dataWrong output, wrong rendering, wrong datapain:ci-timeSlow gates and workflowsSlow gates and workflowsuse-model:cheapCheapest tier suffices: mechanical/templated work (e.g. Haiku-class)Cheapest tier suffices: mechanical/templated work (e.g. Haiku-class)
Description
Activity
Metadata
Metadata
Assignees
Labels
P3Later — low urgency, backlogLater — low urgency, backlogarea:benchbench/ — SWE-bench & Arena harnessbench/ — SWE-bench & Arena harnessarea:ciGitHub Actions, release pipeline, packagingGitHub Actions, release pipeline, packagingpain:accuracyWrong output, wrong rendering, wrong dataWrong output, wrong rendering, wrong datapain:ci-timeSlow gates and workflowsSlow gates and workflowsuse-model:cheapCheapest tier suffices: mechanical/templated work (e.g. Haiku-class)Cheapest tier suffices: mechanical/templated work (e.g. Haiku-class)
Problem
nightly-benchgates on loop health, and #5613 fixed the classification thatheld it red: a steering warning the turn survived is no longer scored as a
stuck loop. That fix is proved by two unit tests and by a census of the recorded
streams from four red nights. A dispatched run on the fix branch
(33973144575) is green with
LOOP: 0/4 broken, but no detection fired in anyof its four streams, so that run alone cannot tell the new code from the old.
One run is not the acceptance test the original issue asked for. Its last
definition-of-done item was "
nightly-benchruns green ten consecutive nightswith
LOOP: 4/4", which cannot be ticked before the merge that produces thosenights, so it moves here.
What to do
Watch
.github/workflows/nightly-bench.ymlfor ten consecutive scheduled runsafter the merge of #5613.
LOOP: 4/4on all ten: close this, and say so on nightly-bench has been red for two weeks: the loop gate keeps catching a real stuck loop #5613.loop-bench-<run id>and openevents/<task>__<id>.jsonl, then count theloop_detectedevents by theirabortedfield.aborted: trueis a realstuck loop and the row is correct — that is an engine finding, and it gets
its own issue.
aborted: falsealone must no longer produceSTUCK-LOOP; ifit does, the fix regressed and this issue is where that is reported.
A
CRASHEDnight is a different signal and is tracked separately — see theharbor-timeout issue linked from #5613.
Files
.github/workflows/nightly-bench.yml— the workflow and its pinned task set.bench/loop-bench/src/lib.rs— the verdict vocabulary and the two counters(
loop_detected,loop_aborted).Definition of done
nightly-benchruns after nightly-bench has been red for two weeks: the loop gate keeps catching a real stuck loop #5613 merged arelisted here with their run ids and their
LOOP:line.explanation names whether a detection aborted.