Skip to content

Watch nightly-bench for ten nights after the loop-gate fix #6024

Description

@macanderson

Problem

nightly-bench gates on loop health, and #5613 fixed the classification that
held it red: a steering warning the turn survived is no longer scored as a
stuck loop. That fix is proved by two unit tests and by a census of the recorded
streams from four red nights. A dispatched run on the fix branch
(33973144575) is green with LOOP: 0/4 broken, but no detection fired in any
of its four streams, so that run alone cannot tell the new code from the old.

One run is not the acceptance test the original issue asked for. Its last
definition-of-done item was "nightly-bench runs green ten consecutive nights
with LOOP: 4/4", which cannot be ticked before the merge that produces those
nights, so it moves here.

What to do

Watch .github/workflows/nightly-bench.yml for ten consecutive scheduled runs
after the merge of #5613.

  • Green with LOOP: 4/4 on all ten: close this, and say so on nightly-bench has been red for two weeks: the loop gate keeps catching a real stuck loop #5613.
  • A red night: read its artifact before concluding anything. Download
    loop-bench-<run id> and open events/<task>__<id>.jsonl, then count the
    loop_detected events by their aborted field. aborted: true is a real
    stuck loop and the row is correct — that is an engine finding, and it gets
    its own issue. aborted: false alone must no longer produce STUCK-LOOP; if
    it does, the fix regressed and this issue is where that is reported.
gh api repos/macanderson/stella/actions/runs/<run id>/artifacts
gh api repos/macanderson/stella/actions/artifacts/<artifact id>/zip > a.zip

A CRASHED night is a different signal and is tracked separately — see the
harbor-timeout issue linked from #5613.

Files

  • .github/workflows/nightly-bench.yml — the workflow and its pinned task set.
  • bench/loop-bench/src/lib.rs — the verdict vocabulary and the two counters
    (loop_detected, loop_aborted).

Definition of done

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Later — low urgency, backlogarea:benchbench/ — SWE-bench & Arena harnessarea:ciGitHub Actions, release pipeline, packagingpain:accuracyWrong output, wrong rendering, wrong datapain:ci-timeSlow gates and workflowsuse-model:cheapCheapest tier suffices: mechanical/templated work (e.g. Haiku-class)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions