Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes inside modules are not auto-rendering or being documenteed #197

Closed
hamelsmu opened this issue Jun 24, 2023 · 2 comments
Closed

classes inside modules are not auto-rendering or being documenteed #197

hamelsmu opened this issue Jun 24, 2023 · 2 comments
Assignees

Comments

@hamelsmu
Copy link
Collaborator

I'm trying to use quartodoc against bytewax in the bytewax branch of this repo

The quarto.yml file is like this:

project:
  type: website

website:
  title: "."
  navbar:
    left:
      - href: index.qmd
        text: Home
      - about.qmd

format:
  html:
    theme: cosmo
    css: styles.css
    toc: true

# tell quarto to read the generated sidebar
metadata-files:
  - _sidebar.yml

quartodoc:
  # the name used to import the package
  package: bytewax

  # write sidebar data to this file
  sidebar: _sidebar.yml

  sections:
    - title: General utilities
      desc: General purpose utilities.
      dynamic: true
      contents:
        # the functions being documented in the package.
        # you can refer to anything: class methods, modules, etc..
        - outputs
        - recovery
        - testing
    - title: Documentation utilities
      desc: Utilities for documentation.
      dynamic: true
      contents:
        - tracing
        - window
        - inputs

For example, there are many objects in the outputs module, however that page doesn't contain anything and looks like this without any functions, or classes even though those exist in this module.

image

You can repro this by checking out the bytewax branch of this repo and running quartodoc build followed by quarto preview

@machow
Copy link
Owner

machow commented Jun 27, 2023

From pairing w/ Hamel --

  • Currently, we only document functions and attributes on modules. Let's plan to document everything on a module.
  • Currently, we group functions by kind (e.g. attributes, functions). Let's have a mode that documents sequentially.
    • e.g. each object is documented in the order it appears in the source code
    • similar to mkdocstrings (see here), which looks great

edit: once we address these points, it should also improve the generation of fastcore (cf #194), by removing the function summary table.

@machow machow changed the title objects inside modules are not auto-rendering or being documenteed classes inside modules are not auto-rendering or being documenteed Jul 7, 2023
@machow machow mentioned this issue Jul 7, 2023
@hamelsmu hamelsmu self-assigned this Jul 11, 2023
@hamelsmu
Copy link
Collaborator Author

This looks like it is working now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants