Changing the service name on the service/role metadata causes duplication of metadata

[tosuke]

Problem

After applying changes on the service attribute in the service/role metadata, the metadata on the previous service remains same.

Steps to reproduce

Here are steps for the service metadata. The steps for the role metadata is almost the same.

1. Apply the config to init

resource "mackerel_service" "svc1" {
  name = "tf-svc1"
}

resource "mackerel_service" "svc2" {
  name = "tf-svc2"
}

resource "mackerel_service_metadata" "metadata" {
  service   = mackerel_service.svc1.name
  namespace = "tf"
  metadata_json = jsonencode({
    value : 1
  })
}

2. Apply the updates

--- main.tf
+++ main.tf
@@ -16,7 +16,7 @@
 }
 
 resource "mackerel_service_metadata" "metadata" {
-  service   = mackerel_service.svc1.name
+  service   = mackerel_service.svc2.name
   namespace = "tf"
   metadata_json = jsonencode({
     value : 1

Expected Behaviour

Only tf-svc2/tf is exists.

Actual Behaviour

Both tf-svc1/tf and tf-svc2/tf are exists.

$ curl -H X-Api-Key:$MACKEREL_APIKEY https://api.mackerelio.com/api/v0/services/tf-svc2/metadata/tf
{"value":1}
$ curl -H X-Api-Key:$MACKEREL_APIKEY https://api.mackerelio.com/api/v0/services/tf-svc1/metadata/tf
{"value":1}

Environment

darwin-amd64, version: 0.4.0

Solution

Because the service attribute on service/role metadata is act as a part of the identifier, this change should be treat as replacement.

terraform-provider-mackerel/mackerel/resource_mackerel_service_metadata.go

Lines 24 to 39 in 9a863e6

	Schema: map[string]*schema.Schema{
	"service": {
	Type: schema.TypeString,
	Required: true,
	},
	"namespace": {
	Type: schema.TypeString,
	Required: true,
	ForceNew: true,
	},
	"metadata_json": {
	Type: schema.TypeString,
	Required: true,
	ValidateFunc: validation.StringIsJSON,
	},
	},