Fixed a crash on macOS <= 10.14: NSMenu.items is not writeable.

macmade · macmade · commit c706a969ee4b · 2022-11-16T16:41:28.000+01:00
diff --git a/Hot/Classes/ApplicationDelegate.swift b/Hot/Classes/ApplicationDelegate.swift
@@ -352,10 +352,17 @@ class ApplicationDelegate: NSObject, NSApplicationDelegate, NSWindowDelegate
         }
 
         self.sensorViewControllers = controllers
-        self.sensorsMenu.items     = items.sorted
+        
+        self.sensorsMenu.removeAllItems()
+
+        items.sorted
         {
             $0.title.compare( $1.title, options: [ .numeric, .caseInsensitive ], range: nil, locale: nil ) == .orderedAscending
         }
+        .forEach
+        {
+            self.sensorsMenu.addItem( $0 )
+        }
     }
 
     @IBAction

Original file line number	Diff line number	Diff line change
`@@ -352,10 +352,17 @@ class ApplicationDelegate: NSObject, NSApplicationDelegate, NSWindowDelegate`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`self.sensorViewControllers = controllers`
`355`		`- self.sensorsMenu.items = items.sorted`
	`355`	`+`
	`356`	`+ self.sensorsMenu.removeAllItems()`
	`357`	`+`
	`358`	`+ items.sorted`
`356`	`359`	`{`
`357`	`360`	`$0.title.compare( $1.title, options: [ .numeric, .caseInsensitive ], range: nil, locale: nil ) == .orderedAscending`
`358`	`361`	`}`
	`362`	`+ .forEach`
	`363`	`+ {`
	`364`	`+ self.sensorsMenu.addItem( $0 )`
	`365`	`+ }`
`359`	`366`	`}`
`360`	`367`
`361`	`368`	`@IBAction`