Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Up-to-date" update window has no focus #17

Open
Gummibando opened this issue Aug 9, 2021 · 7 comments
Open

"Up-to-date" update window has no focus #17

Gummibando opened this issue Aug 9, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Gummibando
Copy link

The "Up-to-date" dialog/window when checking for updates has no focus and can therefore not be dismissed via keyboard (Enter).
I can only bring the window to front by clicking or click-dragging the (default) OK button with the mouse.

Please see attached screen recording.

Hot 1.3.0 (58), macOS 11.5.1 (20G80)

hot_update_window_no_focus.mp4
@macmade
Copy link
Owner

macmade commented Aug 9, 2021

Thanks for reporting this.
I also noticed this behavior. The updater comes from https://github.com/macmade/GitHubUpdates.git

I'll fix it there and close this issue once it's done.

@macmade macmade self-assigned this Aug 9, 2021
@macmade macmade added the bug Something isn't working label Aug 9, 2021
@Gummibando
Copy link
Author

Interestingly, I only see the issue in Hot. DSStoreView or IOBrowser is fine.

@macmade
Copy link
Owner

macmade commented Aug 9, 2021

Yep, that's because Hot is a "status-bar" app.
Focus is a bit different.

@Gummibando
Copy link
Author

That's what I suspected ;)

@macmade macmade closed this as completed Sep 19, 2021
@macmade macmade reopened this Sep 19, 2021
@Gummibando
Copy link
Author

v1.40 – close but not entirely fixed.

Update dialog only has (keyboard) focus when shown for the 2nd time.

@macmade
Copy link
Owner

macmade commented Sep 19, 2021

Yup, sorry, this will be for 1.4.1...

@macmade
Copy link
Owner

macmade commented Sep 19, 2021

I'm leaving this opened...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants