Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: HMMRATAC reproducibility #638

Open
igordot opened this issue Apr 4, 2024 · 2 comments
Open

Q: HMMRATAC reproducibility #638

igordot opened this issue Apr 4, 2024 · 2 comments

Comments

@igordot
Copy link

igordot commented Apr 4, 2024

I noticed that HMMRATAC does not seem to be deterministic. If I run it multiple times, sometimes I get a different number of peaks. I see that there is a --randomSeed parameter that is set by default. Is that not controlling for everything?

@taoliu
Copy link
Contributor

taoliu commented Apr 8, 2024

It is possible that certain functions that we used from Numpy/Scipy/sci-kit-learn/hmmlearn escaped the randomSeed setting. But we do have github action testing for macs3 code to make sure that everytime we update the codes, the results should be at least 'similar'. Do you know how big the difference is?

@igordot
Copy link
Author

igordot commented Apr 8, 2024

The differences are variable. For example, 4,000 to 5,400, 2,600 to 2,100, 3,100 to 8,100. Obviously, these are not very good samples, so that may have something to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants