Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridSearchCV and other metaoptimzer should allow an other Optimizer as input #90

Closed
AKuederle opened this issue Aug 30, 2023 · 2 comments

Comments

@AKuederle
Copy link
Member

At the moment GridSearchCV allows to accepts a pipeline as input that it then wraps internally in Optimize. As a result, we need to forward parameters to Optimize and there is no way for a user to wrap another Optimizer into GridSearchCV.

A solution could be to allow passing a Optimizer instance to GridSearchCV directly. The only downside is, that you would need to nest the naming for the Parameter Grid one level deeper, which can become annoying

@AKuederle
Copy link
Member Author

Maybe we could add a "prefix_parameter_names" attribute, that could be set, if you pass a complicated chain of nested Optimizers. Might also be helpful in case of #84

@AKuederle
Copy link
Member Author

I decided against this for now, as this might make things much more complicated. However in #116 I extracted the part of the GridSearchCV method, where we wrap the pipeline into a separate function. So in case someone really needs it, they could subclass GridSearchCV to get another type of optimizer working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant