Skip to content

Commit 8ace456

Browse files
authored
fix: some fixes for karpenter deploy (#358)
1 parent dde6003 commit 8ace456

File tree

5 files changed

+29
-13
lines changed

5 files changed

+29
-13
lines changed

terraform/modules/k8s-karpenter/main.tf

+5-9
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ locals {
33
karpenter = {
44
name = try(var.helm.release_name, "karpenter")
55
enabled = true
6-
chart = try(var.helm.chart_name, "karpenter")
7-
repository = try(var.helm.repository, "oci://public.ecr.aws/karpenter")
8-
chart_version = try(var.helm.chart_version, "1.0.0")
6+
chart = try(var.helm.chart_name, "oci://public.ecr.aws/karpenter/karpenter")
7+
repository = try(var.helm.repository, "")
8+
chart_version = try(var.helm.chart_version, "1.0.3")
99
namespace = try(var.helm.namespace, "karpenter")
1010
}
1111

@@ -30,8 +30,6 @@ controller:
3030
VALUES
3131
}
3232

33-
data "aws_ecrpublic_authorization_token" "token" {}
34-
3533
module "this" {
3634
count = local.karpenter.enabled ? 1 : 0
3735

@@ -66,7 +64,7 @@ resource "kubectl_manifest" "ec2nodeclass_private" {
6664
count = local.karpenter.enabled ? 1 : 0
6765

6866
yaml_body = <<EOF
69-
apiVersion: karpenter.sh/v1
67+
apiVersion: karpenter.k8s.aws/v1
7068
kind: EC2NodeClass
7169
metadata:
7270
name: private
@@ -98,7 +96,7 @@ resource "kubectl_manifest" "ec2nodeclass_public" {
9896
count = local.karpenter.enabled ? 1 : 0
9997

10098
yaml_body = <<EOF
101-
apiVersion: karpenter.sh/v1
99+
apiVersion: karpenter.k8s.aws/v1
102100
kind: EC2NodeClass
103101
metadata:
104102
name: public
@@ -144,8 +142,6 @@ resource "helm_release" "this" {
144142
version = local.karpenter.chart_version
145143
namespace = module.namespace[count.index].name
146144
max_history = 3
147-
repository_username = data.aws_ecrpublic_authorization_token.token.user_name
148-
repository_password = data.aws_ecrpublic_authorization_token.token.password
149145

150146
values = [
151147
local.karpenter_values

terragrunt/ACCOUNT_ID/us-east-1/demo/common/aws-eks/.terraform.lock.hcl

+8-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

terragrunt/ACCOUNT_ID/us-east-1/demo/common/aws-vpc/.terraform.lock.hcl

+2-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

terragrunt/ACCOUNT_ID/us-east-1/demo/env.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ eks_karpenter_nodepools:
2828

2929
spec:
3030
nodeClassRef:
31+
group: karpenter.k8s.aws
32+
kind: EC2NodeClass
3133
name: private
3234

3335
requirements:
@@ -68,6 +70,7 @@ eks_karpenter_nodepools:
6870

6971
disruption:
7072
consolidationPolicy: WhenEmptyOrUnderutilized
73+
consolidateAfter: 1m
7174

7275
limits:
7376
cpu: "1000"
@@ -85,6 +88,8 @@ eks_karpenter_nodepools:
8588

8689
spec:
8790
nodeClassRef:
91+
group: karpenter.k8s.aws
92+
kind: EC2NodeClass
8893
name: public
8994

9095
taints:
@@ -130,6 +135,7 @@ eks_karpenter_nodepools:
130135

131136
disruption:
132137
consolidationPolicy: WhenEmptyOrUnderutilized
138+
consolidateAfter: 1m
133139

134140
limits:
135141
cpu: "1000"

terragrunt/ACCOUNT_ID/us-east-1/demo/karpenter/.terraform.lock.hcl

+8-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)