Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Low priority) Move nwf from CPPProcess.cc to CPPProcess.h in cudacpp? #677

Open
valassi opened this issue Jun 3, 2023 · 0 comments
Open

Comments

@valassi
Copy link
Member

valassi commented Jun 3, 2023

(This is a followup to #644 and a possible improvement for the solution in MR #560)

Hi @nscottnichols thanks for your comment #671 (comment)

IIUC it should be possible to move nwf from CPPProcess.cc to CPPProcess.h by properly controlling the order of function calls in the python code generation. I agree, as I initially was not even able to include nwf in CPPProcess.cc, and I only later realised that I had to call the python functions in some specific order.

I file this as a future reminder, but for the moment it is low priority. As the nwf is moved out of src and into P1, the functional issues are now solved, even if nwf os in CPPProcess.cc. I agree however that it would be nicer to have it in CPPProcess.h, which is also the case of npar in #667

Thanks again Nathan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant