Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts.after callback function called twice #5

Open
cmawhorter opened this issue Feb 18, 2010 · 3 comments
Open

opts.after callback function called twice #5

cmawhorter opened this issue Feb 18, 2010 · 3 comments

Comments

@cmawhorter
Copy link

I'm using FF 3.5.7. I'm not sure if this bug is unique to my browser/setup or not.

To reproduce:
emile( el, 'margin-top:120px;', {duration:150, after:function() { console.log('here'); }} );

"here" is printed twice.

Also, one more unrelated thing: options.after would be significantly more useful if you made one small change to emile.js:

Change line 48 from:
if(time>finish) { clearInterval(interval); opts.after && opts.after(); }

To:
if(time>finish) { clearInterval(interval); opts.after && opts.after.call(el, opts); }

This will make "this" refer to the element being animated in the callback and also provide the options as an argument.

ex:
emile( el, 'margin-top:120px;', {duration:150, after:function() { this.className='justanimated'; }} );

Love emile! Great job!

@TimHeckel
Copy link

Did you ever figure this out? I'm seeing the same thing.

@cmawhorter
Copy link
Author

No. I was just evaluating emile for fun and had no need to, sorry =/

@cmawhorter
Copy link
Author

Just tested in Chrome and FF/5 and I'm no longer seeing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants