ExaModelsCompiler: registration prerequisites - #318
Merged
Conversation
A license file in the subdirectory (AutoMerge inspects the subdir tree, and the repo-root license does not count for a subdir package) and compat bounds for the two non-stdlib dependencies — both required by the registration guidelines for a new package. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
The previous commit claimed both prerequisites and carried one: a quote-collision killed the edit script and the chain ran on, so only the license landed. This is the other half, verified in the diff this time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two blockers for registering ExaModelsCompiler as a subdir package, found by checking the AutoMerge guidelines before firing: the subdirectory has no LICENSE (AutoMerge inspects the subdir tree; the repo root's doesn't count), and
[compat]bounds ExaModels and JuliaC are missing (required for all non-stdlib deps;Pkg/Random/Serialization/TOMLare stdlibs and exempt). MIT copied from the repo root;ExaModels = "0.12",JuliaC = "0.3"(current General release is 0.3.8).Once this merges — and once ExaModels 0.12.0's own registration (fired, in flight) lands in General so the dependency resolves — the registration is one comment:
@JuliaRegistrator register subdir=ExaModelsCompiler.🤖 Generated with Claude Code