Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic is broken when you provide a callback #26

Open
RobinClowers opened this issue Feb 23, 2016 · 1 comment
Open

Retry logic is broken when you provide a callback #26

RobinClowers opened this issue Feb 23, 2016 · 1 comment

Comments

@RobinClowers
Copy link

I just ran into a case where a push failed, but there were no retries. I looked into your code, and this line: https://github.com/mafintosh/sqs/blob/master/index.js#L71 makes it so that retry logic never happens if you provide a callback.

@GeoffreyPlitt
Copy link

@mafintosh Is this repo maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants