We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When piping streams, streamx adds an error listener. This error listener is not cleaned up when the pipe ends (including due to an error).
streamx
error
streamx/index.js
Line 274 in 625ce37
This is unlike Node.js streams, which do clean up any listener added by .pipe():
.pipe()
https://github.com/nodejs/readable-stream/blob/c85db76d4c41f64fd082c9263c3a918bec6f38a0/lib/_stream_readable.js#L639
This bug ends up creating some bigger problem with Gulp, explained here: gulpjs/gulp#2812
The text was updated successfully, but these errors were encountered:
Feel free to open a pr that removes it after the stream has been fully torn down
Sorry, something went wrong.
Hi @mafintosh,
It turns out the problem was slightly different. I opened #94 with the actual issue.
No branches or pull requests
When piping streams,
streamx
adds anerror
listener. Thiserror
listener is not cleaned up when the pipe ends (including due to an error).streamx/index.js
Line 274 in 625ce37
This is unlike Node.js streams, which do clean up any listener added by
.pipe()
:https://github.com/nodejs/readable-stream/blob/c85db76d4c41f64fd082c9263c3a918bec6f38a0/lib/_stream_readable.js#L639
This bug ends up creating some bigger problem with Gulp, explained here: gulpjs/gulp#2812
The text was updated successfully, but these errors were encountered: