Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.4 not compatible with php 8.1? #893

Open
rbrown opened this issue Apr 13, 2022 · 10 comments
Open

2.4.4 not compatible with php 8.1? #893

rbrown opened this issue Apr 13, 2022 · 10 comments

Comments

@rbrown
Copy link

rbrown commented Apr 13, 2022

Sorry, I can't see anywhere mentioning whether this is compatible with 8.1, but after upgrading form 2.4.3, running bin/magento returns

bin/magento setup:upgrade
PHP Fatal error:  During inheritance of Iterator: Uncaught Exception: Deprecated Functionality: Return type of Migration\ResourceModel\AbstractCollection::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /magento2/vendor/magento/data-migration-tool/src/Migration/ResourceModel/AbstractCollection.php on line 35 in /magento2/vendor/magento/framework/App/ErrorHandler.php:61

I don't think it's a caching error, https://github.com/magento/data-migration-tool/blob/2.4-develop/src/Migration/ResourceModel/AbstractCollection.php is not specifying the return type?

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2022

Hi @rbrown. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@DmitryFurs
Copy link
Contributor

It seems like the data-migration-tool should use attributes for places
like in the magento2 repository

@victor-v-rad
Copy link
Collaborator

@rbrown the issue fixed in 2.4-develop Please install DMT from that branch or use php 7.4 as a workaround while migration

@andreidragutu
Copy link

andreidragutu commented May 12, 2022

Please fix ASAP for 2.4.4, we need to install this on Magento Cloud with php 8.1

@tschirmer
Copy link

Same issue

@mrrobotisback
Copy link

@victor-v-rad composer require magento/data-migration-tool:dev-2.4-develop not work.

[InvalidArgumentException]
Could not find package magento/data-migration-tool in a version matching "dev-2.4-develop" and a stability matching "dev".

How can i require 2.4-develop ?

thanks in advance

@andreidragutu
Copy link

Hi, what is the status here? When will a fix be ready for Adobe Commerce 2.4.4?

@vrielsa
Copy link

vrielsa commented Jul 1, 2022

Had the same issue for our client. We applied the PHP 8.1 fixes commit as a patch until it gets released.
https://github.com/magento/data-migration-tool/commit/4341f38400d9eec3e502237337337928620a4f0f.patch

@andreidragutu
Copy link

@victor-v-rad Is this fixed in 2.4.4-p1 or 2.4.5 release? Thanks!

@frozenpandaman
Copy link

Is any fix available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants