Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute set info is cached (EAV cache), but not cleaned after the attribute set updated in admin area #38827

Open
1 of 5 tasks
MaximGns opened this issue Jun 13, 2024 · 4 comments · May be fixed by #38864
Open
1 of 5 tasks

Attribute set info is cached (EAV cache), but not cleaned after the attribute set updated in admin area #38827

MaximGns opened this issue Jun 13, 2024 · 4 comments · May be fixed by #38864
Assignees
@MaximGns
Labels
Area: APIs Component: WebapiAsync Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.6-p5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog

Comments

@MaximGns
Copy link

MaximGns commented Jun 13, 2024 •
edited
Loading

Preconditions and environment

  • Magento version: 2.4.6-p5
  • Anything else that would help a developer reproduce the bug

``

Steps to reproduce

  1. Use the product bulk api.
  2. Create product with required attributes from the attribute set.
  3. Add new attribute to the used attribute set and save
  4. Import the product again using the bulk api having the new attribute in the payload
  5. Attribute value is not saved on the product

Expected result

After a set is being updated and the eav cache is enabled, the related cache key of the set is being cleaned.
Importing the same payload will have all attribute codes saved to the product that are present on the attribute set

Actual result

Product is missing attribute values that are recently added to the set without cleanen the cache manually

Additional information

See: \Magento\Eav\Model\ResourceModel\Entity\Attribute

    protected function _afterSave(AbstractModel $object)
    {
        $this->_saveStoreLabels(
            $object
        )->_saveAdditionalAttributeData(
            $object
        )->saveInSetIncluding(
            $object
        )->_saveOption(
            $object
        );
        $this->getConfig()->clear();
        return parent::_afterSave($object);
    }

Nothing is in place for the Set model: \Magento\Eav\Model\Entity\Attribute\Set

Set info is cached here: \Magento\Eav\Model\ResourceModel\Entity\Attribute\Set::getSetInfo

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jun 13, 2024

Hi @MaximGns. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jun 13, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.6-p5 Indicates original Magento version for the Issue report. label Jun 14, 2024
@MaximGns MaximGns linked a pull request Jun 23, 2024 that will close this issue
Open
5 tasks
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 25, 2024
@engcom-Bravo
Copy link
Contributor

Hi @MaximGns,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Use the product bulk api.
  • Create product with required attributes from the attribute set.
  • Add new attribute to the used attribute set and save
  • Import the product again using the bulk api having the new attribute in the payload
  • Attribute value is not saved on the product
Screenshot 2024-07-02 at 13 17 55 Screenshot 2024-07-02 at 13 18 38

Product is missing attribute values that are recently added to the set.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: WebapiAsync Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: APIs labels Jul 2, 2024
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 2, 2024
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Jul 2, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12321 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 2, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximGns MaximGns

Labels
Area: APIs Component: WebapiAsync Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.6-p5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean eav set cache after Set save or Set delete MaximGns/magento2
3 participants
@MaximGns @engcom-Bravo @github-jira-sync-bot