-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When customer is set for quote order is still a guest order #38540
Comments
Hi @Genaker. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
there is test cases: $customer = $this->customerRepository->getById($customerId);
output 👍 the same issue for quote/cart or for order doesn't matte. |
Hi @engcom-Dash. Thank you for working on this issue.
|
Hi @engcom-November. Thank you for working on this issue.
|
Hello @Genaker, Thank you for the report and contribution! Tried to verify this issue on 2.4-develop, but in our case it is not reproducible. Please take a look at the screenshot below: Please let us know if any preconditions are required for the issue to be reproduced, and also if we are missing anything. Thank you. |
You should submit an order not through the front but by code: it is not a front issue
|
Hello @Genaker, Thank you for the quick response! Verified this issue on 2.4-develop. Please take a look at the screenshot below: Please find the custom module used to reproduce this issue. Thank you. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11689 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
@magento I am working on this |
…order - fix Module Magento\Quote: added $this->setCustomerIsGuest(false) if isset customer Quote for function beforeSave().
…order - The object $this->_customer always exists. Added a check for the existence of $this->getCustomerId() / If it is true $this->setCustomerIsGuest(false);
@magento I am working on this |
Ivan. Thank you For making Magento great again!
…On Sun, Nov 3, 2024 at 6:54 AM Ivan Shm ***@***.***> wrote:
@magento <https://github.com/magento> I am working on this
—
Reply to this email directly, view it on GitHub
<#38540 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGJNZWZQYO2LXNLO7XHEOLZ6Y2JVAVCNFSM6AAAAABFCROPFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGQ2TKNRWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
magento2/app/code/Magento/Quote/Model/Quote.php
Lines 859 to 861 in a98a64a
if ($this->_customer) {
$this->setCustomerId($this->_customer->getId());
}
You need to change it to
if ($this->_customer) {
$this->setCustomerId($this->_customer->getId());
$this->setCustomerIsGuest(0);
}
or incapsulate this logic into setCustomerId() method
Additional Information:
This issue is caused when checking out from a guest cart programmatically, when you assign a customer to the cart before submitting it to place the order, the quote remains as guest even though a customer has been assigned.
The text was updated successfully, but these errors were encountered: