Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email template store-switcher #38892

Open
1 of 5 tasks
vandijkstef opened this issue Jul 2, 2024 · 11 comments · May be fixed by #39366
Open
1 of 5 tasks

Email template store-switcher #38892

vandijkstef opened this issue Jul 2, 2024 · 11 comments · May be fixed by #39366
Assignees
@lucafuser
Labels
Area: Admin UI Component: Email Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@vandijkstef
Copy link

vandijkstef commented Jul 2, 2024 •
edited
Loading

Preconditions and environment

Steps to reproduce

  • Open an email template preview (newsletter module)
  • Try to open the store switcher

Expected result

An opened store switcher

Actual result

Click is ignored, nothing happens.

Additional information

Magento/Module_Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml is containing deprecated jQuery 'onload' code.

Currently:

jQuery("#preview_iframe").load(function() {
    jQuery(this).height(jQuery(this).contents().find("html").height() );
});

Needs to be:

jQuery("#preview_iframe").on('load', function() {
    jQuery(this).height(jQuery(this).contents().find("html").height() );
});

Furthermore there needs to be checked where ).load( is still being used.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 2, 2024

Hi @vandijkstef. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Jul 2, 2024
@engcom-Dash engcom-Dash self-assigned this Jul 2, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 2, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link
Contributor

Hi @vandijkstef

Thanks for reporting and collaboration.

Verified the issue on the Magento 2.4 dev instance and the issue is reproducible.

Click is ignored, nothing happens when the Newsletter template is opened and try to switch store

Steps to reproduce
Open an email template preview (newsletter module)
Try to open the store switcher

Please refer to the attached screen recording.

38892_Confirmed.mov

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Email Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI labels Jul 4, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12334 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 4, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 4, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
@lucafuser
Copy link

@magento I am working on this

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 13, 2024

Hi @lucafuser! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@lucafuser
Copy link

@magento add to contributors team

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 13, 2024

Hi @lucafuser! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@lucafuser
Copy link

@magento add to contributors team

@lucafuser
Copy link

@magento I am working on this

lucafuser added a commit to lucafuser/magento2 that referenced this issue Nov 13, 2024
@lucafuser
magento#38892: Email template store-switcher
28627c8 
- Fix issue with jQuery deprecated load method
@lucafuser lucafuser linked a pull request Nov 13, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucafuser lucafuser

Labels
Area: Admin UI Component: Email Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
Status: Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magento/magento2#38892: Email template store-switcher lucafuser/magento2
5 participants
@vandijkstef @lucafuser @engcom-Hotel @engcom-Dash @github-jira-sync-bot