Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Magento was sneaked in as part of the Computed Resolver work #90

Open
pawel-siejba opened this issue Oct 21, 2021 · 0 comments

Comments

@pawel-siejba
Copy link

This package has no declared composer dependencies on Magento, yet in 6d25b49 a dependency is hardcoded.

This means that it cannot be considered anymore as a standalone implementation of upward in PHP.

Following Dependency Inversion principle we should create an interface which \Magento\UpwardConnector\Model\ComputedPool implements, or make \Magento\UpwardConnector\Model\ComputedPool part of the magento/upward-php together with \Magento\UpwardConnector\Api\ComputedInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant