Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 to test suite #60

Open
RobRuana opened this issue Mar 8, 2017 · 3 comments
Open

Add flake8 to test suite #60

RobRuana opened this issue Mar 8, 2017 · 3 comments

Comments

@RobRuana
Copy link
Contributor

RobRuana commented Mar 8, 2017

As a developer, I want a machine to double check my work to ensure that I am committing quality code.

From the flake8 manpage:

flake8 is a command-line utility for enforcing style consistency across Python projects. By default it includes lint checks provided by the PyFlakes project, PEP-0008 inspired style checks provided by the PyCodeStyle project, and McCabe complexity checking provided by the McCabe project. It will also run third-party extensions if they are found and installed.

@RobRuana RobRuana self-assigned this Mar 8, 2017
@EliAndrewC
Copy link
Contributor

FWIW, we're already using pep8 (https://pypi.python.org/pypi/pep8) for Sideboard itself and for all of the Sideboard plugins that MAGFest writes.

With that being said, I don't have any strong attachment to pep8 and would be fine with switching to something better.

@RobRuana
Copy link
Contributor Author

RobRuana commented Mar 8, 2017

Good news! Flake8 includes pep8!

Also, I can't find where in the sideboard project pep8 is being invoked :(

@EliAndrewC
Copy link
Contributor

Whoops, I guess we added that in the past several months where I work. I just opened a new PR that includes pep8 at #62

No urgency on it, but it includes a few other things we'll eventually find helpful.

@RobRuana RobRuana removed their assignment Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants