Fix deprecated copy warning in TCommandSet

magiblot · magiblot · commit 646168a38bcc · 2024-09-24T13:28:45.000+02:00
warning: implicitly-declared ‘constexpr TCommandSet&amp; TCommandSet::operator=(const TCommandSet&amp;)’ is deprecated [-Wdeprecated-copy]
note: because ‘TCommandSet’ has user-provided ‘TCommandSet::TCommandSet(const TCommandSet&amp;)’
diff --git a/include/tvision/views.h b/include/tvision/views.h
@@ -211,6 +211,7 @@ class TCommandSet
 
     TCommandSet() noexcept;
     TCommandSet( const TCommandSet& ) noexcept;
+    TCommandSet& operator = ( const TCommandSet& ) noexcept;
 
     Boolean has( int cmd ) noexcept;
 
diff --git a/source/tvision/tcmdset.cpp b/source/tvision/tcmdset.cpp
@@ -34,9 +34,15 @@ TCommandSet::TCommandSet() noexcept
 }
 
 TCommandSet::TCommandSet( const TCommandSet& tc ) noexcept
+{
+    *this = tc;
+}
+
+TCommandSet& TCommandSet::operator = ( const TCommandSet& tc ) noexcept
 {
     for( int i = 0; i < 32; i++ )
         cmds[i] = tc.cmds[i];
+    return *this;
 }
 
 Boolean TCommandSet::has( int cmd ) noexcept

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,15 @@ TCommandSet::TCommandSet() noexcept`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`TCommandSet::TCommandSet( const TCommandSet& tc ) noexcept`
	`37`	`+{`
	`38`	`+ *this = tc;`
	`39`	`+}`
	`40`	`+`
	`41`	`+TCommandSet& TCommandSet::operator = ( const TCommandSet& tc ) noexcept`
`37`	`42`	`{`
`38`	`43`	`for( int i = 0; i < 32; i++ )`
`39`	`44`	`cmds[i] = tc.cmds[i];`
	`45`	`+ return *this;`
`40`	`46`	`}`
`41`	`47`
`42`	`48`	`Boolean TCommandSet::has( int cmd ) noexcept`