Skip to content

feat: add export button pulse animation when ready - #1584

Closed
kunal-yelgate wants to merge 3 commits into
magic-peach:mainfrom
kunal-yelgate:add/pulse
Closed

feat: add export button pulse animation when ready#1584
kunal-yelgate wants to merge 3 commits into
magic-peach:mainfrom
kunal-yelgate:add/pulse

Conversation

@kunal-yelgate

@kunal-yelgate kunal-yelgate commented Jun 16, 2026

Copy link
Copy Markdown

Description

Closes #236

Overview

Adds a subtle pulse animation to the Export button to guide user attention when a file has been loaded and export settings are ready.

Changes

  • Added pulse animation to the Export button when:

    • file is set
    • status === 'idle'
  • Removed the animation when:

    • Export is in progress
    • Export has completed
    • No file is loaded
  • Added support for prefers-reduced-motion to disable the animation for users who have motion reduction enabled.

Testing

  • Verified the pulse animation appears only when the editor is ready to export.
  • Verified the animation stops during export and after export completion.
  • Verified the animation is disabled when prefers-reduced-motion is enabled.
  • Ran local development environment and confirmed expected behavior.

Acceptance Criteria

  • ✅ Subtle pulse animation when ready to export
  • ✅ Animation stops during and after export
  • ✅ Respects prefers-reduced-motion

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

@kunal-yelgate is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @kunal-yelgate!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @kunal-yelgate

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix labels Jun 16, 2026
@kunal-yelgate kunal-yelgate changed the title [fix]: Add pulse animation to Export button when ready to export feat: add export button pulse animation when ready Jun 16, 2026
@kunal-yelgate

Copy link
Copy Markdown
Author

Hey @magic-peach review the PR

@github-actions github-actions Bot added the type:testing Testing label Jun 16, 2026

@kunal-yelgate kunal-yelgate left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the workflow issue

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Jul 8, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 Closing this PR due to inactivity. Feel free to reopen and rebase onto main if you'd like to continue!

@github-actions github-actions Bot closed this Jul 23, 2026
@kunal-yelgate
kunal-yelgate deleted the add/pulse branch July 24, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts needs-fixes PR has issues that need to be fixed type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Add animation to the export button (pulse) when ready to export

1 participant