fix(a11y): improve keyboard focus indicators and navigation - #1668
fix(a11y): improve keyboard focus indicators and navigation#1668Antra1705 wants to merge 1 commit into
Conversation
Signed-off-by: Antra1705 <antra.1705@gmail.com>
|
@Antra1705 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ PR Format Check Passed — @Antra1705Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
👋 Thanks for your PR, @Antra1705!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity. If you need help with this PR, please comment or ping a maintainer. |
|
@magic-peach Hi I have raised the pr but the label says need fixes can you please go through the code and tell if it's good to merge or not? |
Description
Replaces the low-contrast
:focus-visiblebox-shadow (12% opacity--accent-muted) with a prominent 2px offset ring using--accentand--bgCSS variables. Adds a high-contrast mode fallback, refactorsNativeShareButtonhardcoded blue colors to design system tokens, adds.thumb-btn:focus-visiblestyles toThumbnailStrip, adds focus rings toDraggableTextOverlays, updatesBaseButtonwithfocus-visible:*Tailwind classes, and adds aKeyboardNavigation.test.tsxintegration test covering Tab navigation and keyboard activation.Related Issue
Closes #719
Type of Contribution
Participant Info
Screen Recording
Screen.Recording.2026-07-14.at.10.04.45.PM.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in