Merge pull request #634 from magiclabs/force-ctor-preload-iframe

Have the constructor preload iframe assets by default, with optional SDK flag to defer preloading

Author: Dizigen

packages/@magic-sdk/provider/src/core/sdk.ts

@@ -95,6 +95,7 @@ export interface MagicSDKAdditionalConfiguration<
   network?: EthNetworkConfiguration;
   extensions?: TExt;
   testMode?: boolean;
+  deferPreload?: boolean;
 }
 
 export class SDKBase {
@@ -168,6 +169,7 @@ export class SDKBase {
       locale: options?.locale || 'en_US',
       ...(SDKEnvironment.bundleId ? { bundleId: SDKEnvironment.bundleId } : {}),
     });
+    if (!options?.deferPreload) this.preload();
   }
 
   /**

packages/@magic-sdk/provider/test/spec/core/sdk/overlay.spec.ts

@@ -10,7 +10,7 @@ beforeEach(() => {
 
 test('`MagicSDK.overlay` is lazy loaded', async () => {
   const Ctor = createMagicSDKCtor();
-  const magic = new Ctor(TEST_API_KEY);
+  const magic = new Ctor(TEST_API_KEY, { deferPreload: true });
 
   expect((SDKBase as any).__overlays__.size).toBe(0);