You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
Are you running the latest SDK version?
Are you reporting to the correct repository (magic-sdk)?
๐ Description
After upgrading to @magic-sdk/[email protected], builds are failing due to missing exports Events and Wallets enums from @magic-sdk/types. These exports appear to have been removed in PR #742 ("add web3modal extension").
For context:
Our library only uses type imports from @magic-sdk/provider:
The build error occurs because @magic-sdk/provider's distributed code (dist/es/index.mjs) is making runtime imports of the removed exports from @magic-sdk/types.
Build the project using a bundler (in our case, tsup/esbuild)
Observe build errors about missing exports
๐ค Expected behavior
The build should complete successfully, as it did with previous versions of @magic-sdk/provider.
๐ฎ Actual behavior
Build fails with the following errors:
โ [ERROR] No matching export in "@magic-sdk/types/dist/es/index.mjs" for import "Events"
โ [ERROR] No matching export in "@magic-sdk/types/dist/es/index.mjs" for import "Wallets"
Yes it does. Apologies for not realizing that Renovate wasn't installing the latest versions of all packages. After manually upgrading to the latest versions of @magic-ext/algorand, magic-sdk, and @magic-sdk/provider, the builds are successful. Thank you for your help! Closing the issue.
โ Prerequisites
magic-sdk
)?๐ Description
After upgrading to
@magic-sdk/[email protected]
, builds are failing due to missing exportsEvents
andWallets
enums from@magic-sdk/types
. These exports appear to have been removed in PR #742 ("add web3modal extension").For context:
@magic-sdk/provider
:@magic-sdk/provider
's distributed code (dist/es/index.mjs
) is making runtime imports of the removed exports from@magic-sdk/types
.๐งฉ Steps to Reproduce
@magic-sdk/[email protected]
in a project๐ค Expected behavior
The build should complete successfully, as it did with previous versions of
@magic-sdk/provider
.๐ฎ Actual behavior
Build fails with the following errors:
๐ป Code Sample
An example of this failure can be seen in our CI build:
https://github.com/TxnLab/use-wallet/actions/runs/12703649974/job/35411786801?pr=324
Source code:
https://github.com/TxnLab/use-wallet/blob/main/packages/use-wallet/src/wallets/magic.ts
๐ Environment
@magic-sdk/provider
@magic-sdk/types
The text was updated successfully, but these errors were encountered: