CustomNPC 1.18.2 create empty NBT tags

[GodzzilaS]

Minecraft Version: 1.18.2

Forge Version: Client 40.2.0, Server 40.2.21

Logs: Check this https://dropmefiles.com/jo3Fa

Steps to Reproduce:

1. Launch a game only with CustomNPC (latest snapshot)
2. Try to stack items in inventory
3. Try to start smelting items in furnace, open it, and close, and open one more time

Description of issue: CustomNPC creates a empty NBTtags for items, when you interacting with containers/items.

UPD any Additional Information:
[08:45:40] [Netty Server IO #2/ERROR] [no.mo.cr.CreateStuffAdditionsFix/]: Empty NBT tag was created for ItemStack: 2 porkchop
[08:45:40] [Netty Server IO #2/ERROR] [no.mo.cr.CreateStuffAdditionsFix/]: java.base/java.lang.Thread.getStackTrace(Thread.java:1619)
TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.handler$zza000$MagmaTestSetTag(ItemStack.java:1337)
TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.m_41751_(ItemStack.java)
TRANSFORMER/[email protected]/net.minecraftforge.common.extensions.IForgeItem.readShareTag(IForgeItem.java:172)
TRANSFORMER/[email protected]/net.minecraftforge.common.extensions.IForgeItemStack.readShareTag(IForgeItemStack.java:354)
TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_130267_(FriendlyByteBuf.java:480)
TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_178374_(FriendlyByteBuf.java:160)
TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundContainerClickPacket.(ServerboundContainerClickPacket.java:39)
TRANSFORMER/[email protected]/net.minecraft.network.ConnectionProtocol$PacketSet.m_178327_(ConnectionProtocol.java:419)
TRANSFORMER/[email protected]/net.minecraft.network.ConnectionProtocol.m_178321_(ConnectionProtocol.java:471)
TRANSFORMER/[email protected]/net.minecraft.network.PacketDecoder.decode(PacketDecoder.java:32)

This is the output from the mod, which was supposed to track the appearance of empty NBT Tags. But this is didn't create any output when interact with furnace. There are a lot of places where NBT tags are used in the Custom NPC mod, as the source code showed. If necessary, I can share the source texts for any corrections

[TonimatasDEV]

CustomNPC is closed source. I need time for fix it.

[GodzzilaS]

Noppies gived a sources of this mod for me, i can give that to you. Because in this mod a lot of code and i found only 2-3 methods, I was able to fix only the bug in inventory, but not the furnaces, and it's so controversial

[TonimatasDEV]

If you can give me temporary reading access that would be great. Are you tried it in normal Forge and it works? (I think yes but to be sure)

[GodzzilaS]

No, i only tried on all cores (Mohist, CatServer, ArcLight). But i have this screenshot from his discord

Can i share git private repo to you?

[TonimatasDEV]

Yes, you can.

[TonimatasDEV]

It is only a problem with Furnace with your fix?

[GodzzilaS]

On the contrary, I could not fix the oven in any way

[GodzzilaS]

This is about furnace.

Well, the smart developers of other mods said about my fix that it's a bad fix :D

[GodzzilaS]

This is an assumption about why this bug basically happens.

[TonimatasDEV]

Can you send me the jar of the fixed version?

[GodzzilaS]

Where i can send this? Ds?

[TonimatasDEV]

Where i can send this? Ds?

Yes, or comprime in a zip and send here.

[GodzzilaS]

Where i can send this? Ds?

Yes, or comprime in a zip and send here.

Send in discord