Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course editing is buggy #28

Open
Ascent817 opened this issue Jul 28, 2022 · 9 comments
Open

Course editing is buggy #28

Ascent817 opened this issue Jul 28, 2022 · 9 comments
Labels
bug Something isn't working high High priority

Comments

@Ascent817
Copy link
Member

  1. It's possible to delete the field headings:
    image
  2. When cancel is clicked the contents of the card do not revert until reload.
@Ascent817 Ascent817 added the bug Something isn't working label Jul 28, 2022
@GoogleGenius
Copy link
Member

@Ascent817 The contents of the card don't change back because we completely mess up React's handling of the DOM. Honestly, we should revamp this with the modal/form you suggested earlier.

@Ascent817
Copy link
Member Author

I agree. I'm leaning towards a modal, especially since you already implemented one. What do you think?

@GoogleGenius
Copy link
Member

It's a good idea. We really should refactor things so they're more reusable (dynamic components, better CSS, etc.). I often copy and paste code from other elements to have the same style.

@GoogleGenius
Copy link
Member

Btw, we need to be able to store login info longer term, I find it annoying that it completely resets and we have to login again after a page reload.

@Ascent817
Copy link
Member Author

Store with cookies?

@GoogleGenius
Copy link
Member

I think so. Then we need cookie warning lol :)

@Ascent817
Copy link
Member Author

We would be the only people getting cookies lol

@GoogleGenius
Copy link
Member

I feel like we should rerender the DOM after clicking Cancel, though that would be a performance hit hmm.
It's better as a modal.

@GoogleGenius GoogleGenius added the high High priority label Feb 10, 2024
@GoogleGenius
Copy link
Member

This likely needs to be fixed for teachers/admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high High priority
Projects
None yet
Development

No branches or pull requests

2 participants