[OF-1784] refac: Update to use case with logging

Author: MAG-mv

Library/include/CSP/Systems/Multiplayer/Scope.h

@@ -99,6 +99,8 @@ class CSP_API ScopeResult : public ResultBase
     /// @return const Scope& : The scope retrieved by this result.
     const Scope& GetScope() const;
 
+    CSP_NO_EXPORT ScopeResult(csp::systems::EResultCode ResCode, uint16_t HttpResCode);
+
 private:
     ScopeResult(void*) {};
 

Library/src/Systems/Multiplayer/MultiplayerSystem.cpp

@@ -3,6 +3,7 @@
 #include "Services/ApiBase/ApiBase.h"
 #include "Services/MultiplayerService/Api.h"
 #include "Services/MultiplayerService/Dto.h"
+#include "Systems/ResultHelpers.h"
 
 namespace chs = csp::services::generated;
 
@@ -44,13 +45,18 @@ void MultiplayerSystem::UpdateScopeById(const csp::common::String& ScopeId, cons
 
     auto PubSubModelDto = std::make_shared<chs::multiplayerservice::PubSubModel>();
 
-    if (Scope.PubSubType == PubSubModelType::Global)
+    switch (Scope.PubSubType)
     {
+    case PubSubModelType::Global:
         PubSubModelDto->SetValue(chs::multiplayerservice::PubSubModel::ePubSubModel::GLOBAL);
-    }
-    else if (Scope.PubSubType == PubSubModelType::Object)
-    {
+        break;
+    case PubSubModelType::Object:
         PubSubModelDto->SetValue(chs::multiplayerservice::PubSubModel::ePubSubModel::OBJECT);
+        break;
+    default:
+        LogSystem->LogMsg(csp::common::LogLevel::Error, "Invalid PubSubModel type specified");
+        Callback(MakeInvalid<ScopeResult>());
+        return;
     }
 
     Dto->SetPubSubModel(PubSubModelDto);

Library/src/Systems/Multiplayer/Scope.cpp

@@ -55,6 +55,11 @@ void DtoToScope(const chs::multiplayerservice::ScopeDto& Dto, csp::systems::Scop
 
 const Scope& ScopeResult::GetScope() const { return Scope; }
 
+ScopeResult::ScopeResult(csp::systems::EResultCode ResCode, uint16_t HttpResCode)
+    : ResultBase { ResCode, HttpResCode }
+{
+}
+
 void ScopeResult::OnResponse(const csp::services::ApiResponseBase* ApiResponse)
 {
     ResultBase::OnResponse(ApiResponse);