diff --git a/src/main/java/org/dataalgorithms/bonus/friendrecommendation/mapreduce/PairOfLongs.java b/src/main/java/org/dataalgorithms/bonus/friendrecommendation/mapreduce/PairOfLongs.java index 1285aef7..c60861ef 100644 --- a/src/main/java/org/dataalgorithms/bonus/friendrecommendation/mapreduce/PairOfLongs.java +++ b/src/main/java/org/dataalgorithms/bonus/friendrecommendation/mapreduce/PairOfLongs.java @@ -180,10 +180,10 @@ public int compare(byte[] b1, int s1, int l1, byte[] b2, int s2, int l2) { if (thisLeftValue == thatLeftValue) { long thisRightValue = readLong(b1, s1 + 8); long thatRightValue = readLong(b2, s2 + 8); - return (thisRightValue < thatRightValue ? -1 : (thisRightValue == thatRightValue ? 0 : 1)); + return thisRightValue < thatRightValue ? -1 : (thisRightValue == thatRightValue ? 0 : 1); } - return (thisLeftValue < thatLeftValue ? -1 : (thisLeftValue == thatLeftValue ? 0 : 1)); + return thisLeftValue < thatLeftValue ? -1 : (thisLeftValue == thatLeftValue ? 0 : 1); } } diff --git a/src/main/java/org/dataalgorithms/bonus/logquery/spark/SparkLogQuery.java b/src/main/java/org/dataalgorithms/bonus/logquery/spark/SparkLogQuery.java index d165cf25..bcfcb730 100644 --- a/src/main/java/org/dataalgorithms/bonus/logquery/spark/SparkLogQuery.java +++ b/src/main/java/org/dataalgorithms/bonus/logquery/spark/SparkLogQuery.java @@ -98,7 +98,7 @@ public Tuple2, LogStatistics> call(String logReco >() { public Boolean call(Tuple2, LogStatistics> s) { Tuple3 t3 = s._1; - return (t3._1() != null); // exclude Tuple3(null,null,null) + return t3._1() != null; // exclude Tuple3(null,null,null) } }); diff --git a/src/main/java/org/dataalgorithms/bonus/outlierdetection/spark/OutlierDetection.java b/src/main/java/org/dataalgorithms/bonus/outlierdetection/spark/OutlierDetection.java index f502ae79..8c5ccc32 100644 --- a/src/main/java/org/dataalgorithms/bonus/outlierdetection/spark/OutlierDetection.java +++ b/src/main/java/org/dataalgorithms/bonus/outlierdetection/spark/OutlierDetection.java @@ -55,7 +55,7 @@ static class TupleComparatorAscending @Override public int compare(Tuple2 t1, Tuple2 t2) { - return (t1._2.compareTo(t2._2)); // sort based on AVF Score + return t1._2.compareTo(t2._2); // sort based on AVF Score } } diff --git a/src/main/java/org/dataalgorithms/chap09/spark/SparkFriendRecommendation.java b/src/main/java/org/dataalgorithms/chap09/spark/SparkFriendRecommendation.java index beb67bd1..f79112ad 100755 --- a/src/main/java/org/dataalgorithms/chap09/spark/SparkFriendRecommendation.java +++ b/src/main/java/org/dataalgorithms/chap09/spark/SparkFriendRecommendation.java @@ -117,7 +117,7 @@ public String call(Iterable> values) { for (Tuple2 t2 : values) { final Long toUser = t2._1; final Long mutualFriend = t2._2; - final boolean alreadyFriend = (mutualFriend == -1); + final boolean alreadyFriend = mutualFriend == -1; if (mutualFriends.containsKey(toUser)) { if (alreadyFriend) { diff --git a/src/main/java/org/dataalgorithms/chap24/spark/SparkDNABaseCountFASTA.java b/src/main/java/org/dataalgorithms/chap24/spark/SparkDNABaseCountFASTA.java index 9602cd88..6aba9686 100644 --- a/src/main/java/org/dataalgorithms/chap24/spark/SparkDNABaseCountFASTA.java +++ b/src/main/java/org/dataalgorithms/chap24/spark/SparkDNABaseCountFASTA.java @@ -81,7 +81,7 @@ public Iterable> call(Iterator iter) { allBaseCounts.put(base, entry.getValue()); } else { - allBaseCounts.put(base, (count + entry.getValue())); + allBaseCounts.put(base, count + entry.getValue()); } } }