Skip to content

Commit b9c7ea0

Browse files
committed
removed some debugging stuff and added a check to get cags on close modal
1 parent 76fb9ae commit b9c7ea0

File tree

2 files changed

+32
-12
lines changed

2 files changed

+32
-12
lines changed

devU-client/src/components/pages/forms/assignments/assignmentUpdatePage.tsx

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ const AssignmentUpdatePage = () => {
3434
const currentAssignmentId = parseInt(assignmentId)
3535
const [assignmentProblems, setAssignmentProblems] = useState<AssignmentProblem[]>([])
3636
const [nonContainerAutograders, setNonContainerAutograders] = useState<NonContainerAutoGrader[]>([])
37-
const [containerAutoGraderModal, setContainerAutoGraderModal] = useState(false);
38-
const handleCloseContainerAutoGraderModal = () => setContainerAutoGraderModal(false);
3937
const [containerAutograders, setContainerAutograders] = useState<ContainerAutoGrader[]>([])
4038

4139

@@ -111,11 +109,18 @@ const AssignmentUpdatePage = () => {
111109
}
112110

113111
const fetchAssignmentProblems = async () => {
114-
await RequestService.get(`/api/course/${courseId}/assignment/${assignmentId}/non-container-auto-graders`)
115-
.then((res) => { setNonContainerAutograders(res) })
116112
await RequestService.get(`/api/course/${courseId}/assignment/${currentAssignmentId}/assignment-problems`)
117113
.then((res) => { setAssignmentProblems(res) })
118114
}
115+
const fetchNcags = async () => {
116+
await RequestService.get(`/api/course/${courseId}/assignment/${assignmentId}/non-container-auto-graders`)
117+
.then((res) => { setNonContainerAutograders(res) })
118+
}
119+
const fetchCags = async () => {
120+
await RequestService.get(`/api/course/${courseId}/assignment/${assignmentId}/container-auto-graders`)
121+
.then((res) => { setContainerAutograders(res) })
122+
}
123+
119124

120125

121126

@@ -210,20 +215,31 @@ const AssignmentUpdatePage = () => {
210215
const handleCloseTextModal = () => {
211216
setTextModal(false)
212217
fetchAssignmentProblems()
218+
fetchNcags()
213219
}
220+
214221
const [codeModal, setCodeModal] = useState(false);
215222
const handleCloseCodeModal = () => {
216223
setCodeModal(false)
217224
fetchAssignmentProblems()
218225
}
226+
219227
const [mcqModal, setMcqModal] = useState(false);
220228
const handleCloseMcqModal = () => {
221229
setMcqModal(false)
222230
fetchAssignmentProblems()
231+
fetchNcags()
232+
}
233+
234+
const [containerAutoGraderModal, setContainerAutoGraderModal] = useState(false);
235+
const handleCloseContainerAutoGraderModal = () => {
236+
setContainerAutoGraderModal(false);
237+
fetchCags();
223238
}
224239

225240

226241

242+
227243
const handleDeleteProblem = (problemId: number) => {
228244
// const idsToDelete = nonContainerAutograders.filter(ncag => ncag.)
229245
RequestService.delete(`/api/course/${courseId}/assignment/${currentAssignmentId}/assignment-problems/${problemId}`)

devU-client/src/components/pages/forms/containers/containerAutoGraderModal.tsx

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,21 @@ const ContainerAutoGraderForm = ({ open, onClose }: Props) => {
4545
}
4646
const handleJobFiles = (e: React.ChangeEvent<HTMLInputElement>) => {
4747
if (!e.target.files) {return}
48-
console.log(e.target.files)
49-
console.log(Array.from(e.target.files))
50-
5148
setJobFiles(Array.from(e.target.files))
5249
}
5350
const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
5451
const key = e.target.id;
5552
const value = e.target.value;
5653
setFormData(prevState => ({ ...prevState, [key]: value }));
5754
};
58-
59-
60-
55+
const isSubmittable = () => {
56+
if (dockerfile && jobFiles && formData.timeout.length > 0){
57+
return true;
58+
}
59+
return false;
60+
}
6161
const handleSubmit = () => {
62-
if (!dockerfile || !jobFiles) return;
62+
if (!dockerfile || !jobFiles) {return}
6363

6464
const body = new FormData
6565
body.append('assignmentId', formData.assignmentId)
@@ -98,7 +98,11 @@ const ContainerAutoGraderForm = ({ open, onClose }: Props) => {
9898
}
9999

100100
return (
101-
<Modal title="Add Container Auto Grader" buttonAction={handleSubmit} open={open} onClose={onClose}>
101+
<Modal title="Add Container Auto Grader"
102+
buttonAction={handleSubmit}
103+
open={open}
104+
onClose={onClose}
105+
isSubmittable={isSubmittable}>
102106
<div className="input-group">
103107
<label htmlFor="dockerfile">Dockerfile*:</label>
104108
<input type="file" id="graderFile" onChange={handleDockerfile} />

0 commit comments

Comments
 (0)