Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support message building #70

Open
krzysztof-ciszewski opened this issue Sep 7, 2016 · 0 comments
Open

Support message building #70

krzysztof-ciszewski opened this issue Sep 7, 2016 · 0 comments

Comments

@krzysztof-ciszewski
Copy link

krzysztof-ciszewski commented Sep 7, 2016

I do not personally understand why the Message class is tightly coupled with the Client class. It doesn't make sense to me that it can send itself.
I think that if you want to have an explicit message you should explicitly send it.
It also makes it hard to separate the message creation logic from the sending logic since you would have to pass a useless client that you won't use everywhere.
I propose adding HeadlessMessage or a similar class that doesn't require the client in it's constructor.

alek13 added a commit to php-slack/slack that referenced this issue Feb 5, 2021
alek13 added a commit to php-slack/slack that referenced this issue Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant