Skip to content

Commit c363d28

Browse files
committed
improvement(@twilio-labs/serverless-runtime-types, @twilio/runtime-handler, twilio-run): Twilio SDK
Twilio SDK bump from 3.x to 4.23 with fixes to types, tests BREAKING CHANGE: Underlying Twilio SDK was bumped by a major version, Twilio SDK 3.x to 4.23. This might require changes in how importing this package will work. fix twilio-labs#473 twilio-labs#483 twilio-labs#455
1 parent e538ef5 commit c363d28

File tree

6 files changed

+7
-5
lines changed

6 files changed

+7
-5
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,5 @@ dist/
7474
packages/serverless-api/docs/
7575

7676
.idea
77+
78+
**/.DS_Store

packages/runtime-handler/__tests__/dev-runtime/route.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
jest.mock('../../node_modules/twilio', () => {
1+
jest.mock('../../../../node_modules/twilio', () => {
22
// because we don't do a traditional require of twilio but a "project require" we have to mock this differently.
33

44
const actualTwilio = jest.requireActual('twilio');

packages/runtime-handler/__tests__/dev-runtime/utils/requireFromProject.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { join } from 'path';
22
import { requireFromProject } from '../../../src/dev-runtime/utils/requireFromProject';
33

44
const PROJECT_DIR = join(__dirname, '../../../../twilio-run');
5-
5+
// only works if test-dep version is different from root package version
66
jest.mock('../../../../twilio-run/node_modules/@twilio/test-dep', () => {
77
const x = jest.genMockFromModule('@twilio/test-dep');
88
(x as any)['__TYPE__'] = 'PROJECT_BASED';

packages/runtime-handler/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"clean": "rimraf ./dist ./node_modules"
4040
},
4141
"devDependencies": {
42-
"@twilio/test-dep": "npm:twilio@4.23.0",
42+
"@twilio/test-dep": "npm:twilio@4.22.0",
4343
"@types/common-tags": "^1.8.0",
4444
"@types/cookie-parser": "^1.4.2",
4545
"@types/debug": "^4.1.4",

packages/twilio-run/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
"nock": "^12.0.2",
114114
"supertest": "^3.1.0",
115115
"typescript": "^4.9.4",
116-
"@twilio/test-dep": "npm:twilio@4.23.0"
116+
"@twilio/test-dep": "npm:twilio@4.22.0"
117117
},
118118
"files": [
119119
"bin/",

packages/twilio-run/src/utils/logger.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ClientApiError } from '@twilio-labs/serverless-api/dist/utils/error';
1+
import { ClientApiError } from '@twilio-labs/serverless-api/src/utils/error';
22
import ora from 'ora';
33
import { Writable } from 'stream';
44
import terminalLink from 'terminal-link';

0 commit comments

Comments
 (0)