casio/pv1000.cpp: wrong naming for the sound device

[angelosa]

DEFINE_DEVICE_TYPE(PV1000, pv1000_sound_device, "pv1000_sound", "NEC D65010G031")

Declares a misleading PV1000 device that should be a PV1000_SOUND at very least, also the (μP?)D65010G031 is actually a gate array, configured for sound in this context but not necessarily a sound device (i.e. Casio FP-200 reuses it for video instead).

[happppp]

Did you open an issue because you wanted to discuss first? This is a 1-minute commit to correct it =)
Yes it looks like the device name should be PV1000_SOUND, and the string something like "Casio PV1000 Sound"

[angelosa]

Did you open an issue because you wanted to discuss first?

Yeah, that's the idea :)

[lidnariq]

Photo of the FP-200 PCB shows that the gate array is µPD65010G030, the immediate previous order.

[cuavas]

There are lots of poorly named sound devices in MAME where the device type name implies it’s the whole system.

[FlykeSpice]

Like these?

./mame/midway/gridlee_a.cpp:DEFINE_DEVICE_TYPE(GRIDLEE, gridlee_sound_device, "gridlee_sound", "Gridlee Custom Sound")
./mame/ussr/tiamc1_a.cpp:DEFINE_DEVICE_TYPE(TIAMC1, tiamc1_sound_device, "tiamc1_sound", "TIA-MC1 Custom Sound")
./mame/capcom/cps3_a.cpp:DEFINE_DEVICE_TYPE(CPS3, cps3_sound_device, "cps3_custom", "CPS3 Custom Sound")
./mame/shared/exidysound.cpp:DEFINE_DEVICE_TYPE(EXIDY, exidy_sound_device, "exidy_sfx", "Exidy SFX")
./mame/exidy/exidy440_a.cpp:DEFINE_DEVICE_TYPE(EXIDY440, exidy440_sound_device, "exidy440_sound", "Exidy 440 CVSD")
./mame/atari/redbaron.cpp:DEFINE_DEVICE_TYPE(REDBARON, redbaron_sound_device, "redbaron_custom", "Red Baron Custom Sound")

[rb6502]

Correct. @angelosa, you want to get all of those?