-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mame.lst
requires either validation or removal
#12568
Comments
mame.lst
requires either validation or just removalmame.lst
requires either validation or removal
You can’t remove it because something needs to reference the driver structures. There’s no portable way to force the linker to include static initialisation for an object with no referenced symbols. Well, to be precise, if you removed it, you’d need to replace it with something else that references the driver structures (or something else in every source file containing driver structures), which would end up effectively being the same thing. There already is some validation:
The only things that aren’t caught automatically is failing to add a new driver to mame.lst, and incorrectly removing a driver from mame.lst when it hasn’t been removed from the source. Failing to add a driver to mame.lst shouldn’t happen if people are actually testing their additions. If you build MAME (even with Inadvertently removing a driver from mame.lst doesn’t seem to be an issue in practice – I don’t recall seeing it happen. If it does, the removal will show up at release time as the script for identifying new/promoted systems also lists apparent removals. |
mame.lst
. A possible CI script doesn't necessarily need to compile MAME but just text search inside but, at the same time ...GAME
and friends rows anyway, no idea about the technical implications at current time.The text was updated successfully, but these errors were encountered: