Remove dependency on Arrow C++ package

Author: alexowens90

cpp/arcticdb/CMakeLists.txt

@@ -935,7 +935,7 @@ endif()
 if(${TEST})
     unset(Python_USE_STATIC_LIBS)
     find_package(Python 3 COMPONENTS Interpreter Development REQUIRED)
-    find_package(Arrow REQUIRED)
+    # find_package(Arrow REQUIRED)
     find_package(rapidcheck REQUIRED)
     find_package(benchmark REQUIRED)
 
@@ -1162,12 +1162,12 @@ if(${TEST})
 
     if(ARCTICDB_USING_CONDA)
         set(RAPIDCHECK_PRIVATE_LIBRARIES
-            ${AWSSDK_LINK_LIBRARIES}
-            Arrow::arrow_shared)
+            ${AWSSDK_LINK_LIBRARIES})
+            # Arrow::arrow_shared)
     else()
         set(RAPIDCHECK_PRIVATE_LIBRARIES
-            ${AWSSDK_LINK_LIBRARIES}
-            "$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Arrow::arrow_static,Arrow::arrow_shared>")
+            ${AWSSDK_LINK_LIBRARIES})
+            # "$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Arrow::arrow_static,Arrow::arrow_shared>")
     endif()
 
     if(WIN32)

cpp/arcticdb/util/test/rapidcheck_decimal.cpp

@@ -10,6 +10,9 @@
 #include <arcticdb/util/test/rapidcheck.hpp>
 #include <arcticdb/util/test/rapidcheck_generators.hpp>
 #include <arcticdb/util/decimal.hpp>
+/* Skipped until arrow dependency in vcpkg can be re-added
+ * Broken by https://github.com/microsoft/vcpkg/pull/44653
+ * We don't seem to be the only people affected https://github.com/microsoft/vcpkg/issues/48496
 #include <arrow/util/decimal.h>
 
 RC_GTEST_PROP(Decimal, BinaryCompatibleWithArrow, ()) {
@@ -26,4 +29,5 @@ RC_GTEST_PROP(Decimal, BinaryCompatibleWithArrow, ()) {
                     sizeof(arrow_decimal)
             ) == 0
     );
-}
+}
+ */

cpp/arcticdb/util/test/rapidcheck_generators.cpp

@@ -8,6 +8,9 @@
 
 #include <gtest/gtest.h>
 #include <arcticdb/util/test/rapidcheck_generators.hpp>
+/* Skipped until arrow dependency in vcpkg can be re-added
+ * Broken by https://github.com/microsoft/vcpkg/pull/44653
+ * We don't seem to be the only people affected https://github.com/microsoft/vcpkg/issues/48496
 #include <arrow/util/decimal.h>
 
 rc::Gen<arrow::Decimal128> rc::Arbitrary<arrow::Decimal128>::arbitrary() {
@@ -28,4 +31,5 @@ rc::Gen<std::string> gen_arrow_decimal128_string() {
             return d.ToString(scale);
         });
     });
-}
+}
+ */

cpp/arcticdb/util/test/rapidcheck_generators.hpp

@@ -232,6 +232,9 @@ inline bool check_test_frame(
     return check_read_frame(data_frame, stream_reader, errors);
 }
 
+/* Skipped until arrow dependency in vcpkg can be re-added
+ * Broken by https://github.com/microsoft/vcpkg/pull/44653
+ * We don't seem to be the only people affected https://github.com/microsoft/vcpkg/issues/48496
 namespace arrow {
 class Decimal128;
 }
@@ -242,5 +245,6 @@ struct Arbitrary<arrow::Decimal128> {
     static Gen<arrow::Decimal128> arbitrary();
 };
 } // namespace rc
+ */
 
-rc::Gen<std::string> gen_arrow_decimal128_string();
+// rc::Gen<std::string> gen_arrow_decimal128_string();

cpp/vcpkg.json

@@ -48,6 +48,7 @@
     "aws-c-sdkutils",
     "aws-c-event-stream",
     "aws-checksums",
+    "boost-locale",
     "boost-dynamic-bitset",
     "boost-interprocess",
     "boost-callable-traits",
@@ -64,10 +65,6 @@
     "libevent",
     "gtest",
     "rapidcheck",
-    {
-      "name": "arrow",
-      "default-features": false
-    },
     "azure-core-cpp",
     "azure-identity-cpp",
     "azure-storage-blobs-cpp",
@@ -77,7 +74,6 @@
   "overrides": [
     { "name": "openssl", "version-string": "3.3.0" },
     { "name": "arcticdb-sparrow", "version": "1.4.0" },
-    { "name": "arrow", "version": "18.1.0" },
     { "name": "aws-sdk-cpp", "version": "1.11.474", "$note": "Update overlay json to upgrade; Upgrade to >=1.11.486 blocked by default integrity change" },
     { "name": "aws-crt-cpp", "version": "0.29.7" },
     { "name": "aws-c-mqtt", "version": "0.11.0" },

environment-dev.yml

@@ -58,7 +58,7 @@ dependencies:
   - libiconv
   - aws-c-s3
   # Build dependencies for tests
-  - libarrow
+  # - libarrow
   # Python dependences
   - python >=3.12,<3.14
   - packaging