From d00fbd5cea8535f2144a1784364e0526289d4c9d Mon Sep 17 00:00:00 2001 From: Julien Jerphanion Date: Thu, 6 Jul 2023 19:10:28 +0200 Subject: [PATCH] wip: End of debug for today The linker fails to find symbols eventhough they are present in both `libprotobuf.dll` and the `libprotobuf.lib`. This has been checked: - `protoc` and `libprotobuf` have the same version (3.20.3) - the linker call for the ultimate target, `arcticdb_ext`, correctly contains the path to `libprotobuf.lib` - `arcticdb_core_static` links successfully while containing the objects of the C++ source files generated by `protoc` - the presence of the 5 symbols reported as "missing" has been checked with `dumpbin` and Dependencies [1] and they are present as exported in both `libprotobuf.dll` and `libprotobuf.lib`. This has been tried: - using `OBJECT` for building intermediary targets. This has not been tried: - checking toolchains and ABI version compatibility with conda-forge's - creating an executable which depends on `arcticdb_core_static` observing if any other specific problems occurs This commit removes the dependence on `libprotobuf-lite` which is redundant with `libprotobuf`. 1: https://github.com/lucasg/Dependencies 2: https://protobuf.dev/support/version-support/#python --- cpp/arcticdb/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/arcticdb/CMakeLists.txt b/cpp/arcticdb/CMakeLists.txt index 87297ec165..80f3fb6a3a 100644 --- a/cpp/arcticdb/CMakeLists.txt +++ b/cpp/arcticdb/CMakeLists.txt @@ -468,7 +468,7 @@ set (arcticdb_core_libraries prometheus-cpp::pull ${standard_libraries} fmt::fmt - ${Protobuf_lite_LIBRARY} + # ${Protobuf_lite_LIBRARY} ${Protobuf_LIBRARY} ${LZ4_LIBRARY} ${Zstd_LIBRARY}