Skip to content

Commit fce2d6f

Browse files
maxim-morozovMaxim Morozov
andauthored
Docs for Mac release (#2761)
#### Reference Issues/PRs Update docs for our mac release and fix some docs and fix the snapshots demo #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> Co-authored-by: Maxim Morozov <[email protected]>
1 parent 8e6763a commit fce2d6f

File tree

4 files changed

+2
-85
lines changed

4 files changed

+2
-85
lines changed

.github/workflows/publish.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,6 @@ jobs:
8484
run-id: ${{ env.RUN_ID }}
8585
github-token: ${{github.token}}
8686

87-
- name: Skip uploading macos wheels for now
88-
run: |
89-
rm *macos*.whl
90-
continue-on-error: true
91-
9287
- name: Upload to Pypi
9388
run: |
9489
ls

CONTRIBUTORS.txt

Lines changed: 0 additions & 24 deletions
This file was deleted.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ ArcticDB is designed from the outset to be resilient; there is no single point o
4949
| --------------------- | - | - |
5050
| Linux (Intel/AMD) | ✔️ | ✔️ |
5151
| Windows (Intel/AMD) | ✔️ ||
52-
| MacOS | Beta | Beta️ |
52+
| MacOS | ✔️ | ✔️ |
5353

5454
For conda-forge see the [release-info](https://github.com/conda-forge/arcticdb-feedstock/?tab=readme-ov-file#current-release-info).
5555

@@ -59,7 +59,7 @@ For conda-forge see the [release-info](https://github.com/conda-forge/arcticdb-f
5959
| --------------------- | - | - | - |
6060
| S3 | ✔️ | ✔️ | ✔️ |
6161
| LMDB | ✔️ | ✔️ | ✔️ |
62-
| Azure Blob Storage | ✔️ | ✔️ | |
62+
| Azure Blob Storage | ✔️ | ✔️ | ✔️ |
6363

6464
We have tested against the following S3 backends:
6565
- AWS S3

docs/mkdocs/docs/notebooks/ArcticDB_demo_snapshots.ipynb

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -390,60 +390,6 @@
390390
"print(vit.data)"
391391
]
392392
},
393-
{
394-
"cell_type": "markdown",
395-
"metadata": {},
396-
"source": [
397-
"### Although it works, we advise not to read snapshot versions directly using the version number\n",
398-
"These versions only exist because they are in a snapshot, so it is much more obvious to code to access them via the snapshot.\n",
399-
"\n",
400-
"Accessing snapshot protected versions via the version number leads to code that will fail (if the snapshot is deleted) in a way that is difficult to understand."
401-
]
402-
},
403-
{
404-
"cell_type": "code",
405-
"execution_count": 18,
406-
"metadata": {},
407-
"outputs": [
408-
{
409-
"name": "stdout",
410-
"output_type": "stream",
411-
"text": [
412-
"VersionedItem(symbol='sym_0', library='demo', data=<class 'pandas.core.frame.DataFrame'>, version=1, metadata=None, host='LMDB(path=/users/isys/nclarke/jupyter/arctic/demos/arcticdb_snapshot_demo)')\n",
413-
" col\n",
414-
"0 10\n"
415-
]
416-
}
417-
],
418-
"source": [
419-
"vit = lib.read(\"sym_0\", as_of=1)\n",
420-
"print(vit)\n",
421-
"print(vit.data)"
422-
]
423-
},
424-
{
425-
"cell_type": "code",
426-
"execution_count": 19,
427-
"metadata": {},
428-
"outputs": [
429-
{
430-
"name": "stderr",
431-
"output_type": "stream",
432-
"text": [
433-
"ERROR:root:Version not found\n"
434-
]
435-
}
436-
],
437-
"source": [
438-
"# version 0 was not in the snapshot, so it has been removed\n",
439-
"try:\n",
440-
" vit = lib.read(\"sym_0\", as_of=0)\n",
441-
" print(vit)\n",
442-
" print(vit.data)\n",
443-
"except adb.exceptions.NoSuchVersionException:\n",
444-
" logging.error(\"Version not found\")\n"
445-
]
446-
},
447393
{
448394
"cell_type": "markdown",
449395
"metadata": {},

0 commit comments

Comments
 (0)