Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1637: append does not respect prune previous #1640

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alexowens90
Copy link
Collaborator

@alexowens90 alexowens90 commented Jun 24, 2024

Fixes #1637

Also fixes some other bugs and inconsistencies in our handling of prune previous:

  • update, delete with a date_range, and defragment_symbol_data also did not respect the prune previous lib config setting/env var.
  • delete with a date_range argument and defragment_symbol_data used prune_previous_versions (i.e. with a trailing s). All other methods use prune_previous_version (i.e. without the trailing s). For backwards compatibility, these two methods now support both variants.
  • write_metadata and delete_data_in_range on the V2 API did not have a prune_previous_versions argument.
  • write_metadata_batch on the V2 API defaulted the argument to None (implying respecting the lib config setting, but this is not a library option on the V2 API), where everything else defaults to False.
  • Homogenised docstrings for prune_previous_versions on V2 API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

append does not respect prune previous
4 participants