-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 1637: append does not respect prune previous #1640
Open
alexowens90
wants to merge
7
commits into
master
Choose a base branch
from
bugfix/1637/append-does-not-respect-prune-previous
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix 1637: append does not respect prune previous #1640
alexowens90
wants to merge
7
commits into
master
from
bugfix/1637/append-does-not-respect-prune-previous
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunro
reviewed
Jun 24, 2024
jamesmunro
reviewed
Jun 24, 2024
poodlewars
reviewed
Jun 24, 2024
python/tests/nonreg/arcticdb/version_store/test_nonreg_specific.py
Outdated
Show resolved
Hide resolved
poodlewars
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1637
Also fixes some other bugs and inconsistencies in our handling of prune previous:
update
,delete
with adate_range
, anddefragment_symbol_data
also did not respect the prune previous lib config setting/env var.delete
with adate_range
argument anddefragment_symbol_data
usedprune_previous_versions
(i.e. with a trailings
). All other methods useprune_previous_version
(i.e. without the trailings
). For backwards compatibility, these two methods now support both variants.write_metadata
anddelete_data_in_range
on the V2 API did not have aprune_previous_versions
argument.write_metadata_batch
on the V2 API defaulted the argument toNone
(implying respecting the lib config setting, but this is not a library option on the V2 API), where everything else defaults toFalse
.prune_previous_versions
on V2 API.