Skip to content

Conversation

@jjerphan
Copy link
Collaborator

@jjerphan jjerphan commented Sep 11, 2025

Reference Issues/PRs

Remaining tests to fix:

  • test_parallel_reads
  • test_parallel_reads_arctic
  • test_force_compact_symbol_list_lock_held_past_ttl

test_compat_write_old_read_new and test_write_new_read_old are the only remaining skipped tests.

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jjerphan jjerphan added the patch Small change, should increase patch version label Sep 11, 2025
@jjerphan jjerphan force-pushed the build/macos branch 4 times, most recently from 1bbf08e to a04c578 Compare September 11, 2025 15:34
@jjerphan jjerphan force-pushed the build/macos branch 2 times, most recently from 40059be to aee03e7 Compare September 23, 2025 12:34
Signed-off-by: Julien Jerphanion <[email protected]>
This reverts commit 63d7f71.
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Collaborator Author

jjerphan commented Oct 15, 2025

The previously failing test completes successfully with one thread:

test_num_storage_operations.py::test_read_as_of_version[MotoNfsBackedS3StorageFixtureFactory-0] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoNfsBackedS3StorageFixtureFactory-1] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoNfsBackedS3StorageFixtureFactory-2] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoNfsBackedS3StorageFixtureFactory-3] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoS3StorageFixtureFactory-0] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoS3StorageFixtureFactory-1] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoS3StorageFixtureFactory-2] PASSED [ 88%]
test_num_storage_operations.py::test_read_as_of_version[MotoS3StorageFixtureFactory-3] PASSED [ 88%]

Let's try to use fork over spawn for multiprocessing on macOS as suggested by @phoebusm.

Edit: it does not work, so the problem needs to be inspected further, for now the test is skipped for those builds.

Signed-off-by: Julien Jerphanion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Small change, should increase patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants