Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map unloading problem #1083

Closed
mns opened this issue Jul 18, 2012 · 3 comments
Closed

Map unloading problem #1083

mns opened this issue Jul 18, 2012 · 3 comments

Comments

@mns
Copy link

mns commented Jul 18, 2012

Somewhen some maps do not unloading after expire

i think this cause lag in high uptime servers .

i use this patch for monitor this issue
https://github.com/mns/mangosR2/commit/025ac35441f3cdfa9ec7f14e0bba5095d50c1df3

result :

Online players: 107 (max: 124) Queued players: 0 (max: 0)
Server uptime: 1 Day(s) 4 Hour(s) 22 Minute(s) 50 Second(s).
Update time diff: 231 loaded maps: 25
ActiveMaps : [Eastern Kingdoms] [Kalimdor] [Outland] [Northrend] [Deeprun Tram]
[Warsong Gulch] [Arathi Basin] [Tempest Keep] [Nagrand Arena] [Blade's Edge Arena]
[Ruins of Lordaeron] [Ruins of Lordaeron] [Ruins of Lordaeron] [Ruins of Lordaeron]
[Ruins of Lordaeron] [The Nexus] [Gundrak] [Strand of the Ancients] [Ebon Hold]
[Dalaran Sewers] [Dalaran Sewers] [Dalaran Sewers] [Dalaran Sewers] [Dalaran Sewers]
[Dalaran Sewers]
@rsa
Copy link
Member

rsa commented Jul 18, 2012

instance maps immediately unload on reset. problem - in 571 map mostly, i'm write some instruments for search this... see #852 and some other.

@RangerRU
Copy link

да, 571 сильно лагает, и чем дольше аптайм, тем всё больше и больше лагает, на данный момент что я увидел идет сильная нагрузка на части кода в циклах:
// the player iterator is stored in the map object
// to make sure calls to Map::Remove don't invalidate it

и

// non-player active objects

причем первое чаще, второе реже

rsa added a commit that referenced this issue Sep 13, 2012
@rsa
use unordered_map instead of TypeUnorderedMapContainer template colle…
e5e8222 
…ction for in-map object storing. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Sep 14, 2012
@rsa
Revert "use unordered_map instead of TypeUnorderedMapContainer templa…
e0cb3e3 
…te collection for in-map object storing. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852"

This reverts commit e5e8222.
rsa added a commit that referenced this issue Sep 14, 2012
@rsa
use unordered_map instead of TypeUnorderedMapContainer template colle…
29ad584 
……ction for in-map object storing v0.2. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852

- fix "dependend spawn" (for example vehicles on BG)
- many simplifyes in code
rsa added a commit that referenced this issue Sep 15, 2012
@rsa
Revert "use unordered_map instead of TypeUnorderedMapContainer templa…
290b2c2 
…te colle…ction for in-map object storing v0.2. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852"

This reverts commit 29ad584.
rsa added a commit that referenced this issue Sep 15, 2012
@rsa
Revert "use unordered_map instead of TypeUnorderedMapContainer templa…
0acf83c 
…te collection for in-map object storing v0.3. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852"
@rsa
Copy link
Member

rsa commented Sep 15, 2012

in #1166

@rsa rsa closed this as completed Sep 15, 2012
rsa added a commit that referenced this issue Sep 16, 2012
@rsa
Revert "Revert "use unordered_map instead of TypeUnorderedMapContaine…
e8c422d 
…r template collection for in-map object storing v0.3. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852""

This reverts commit 0acf83c.
rsa added a commit that referenced this issue Sep 16, 2012
@rsa
use unordered_map instead of TypeUnorderedMapContainer template colle…
1d1b24f 
…ction for in-map object storing v0.5. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Sep 17, 2012
@rsa
Revert "use unordered_map instead of TypeUnorderedMapContainer templa…
fa48767 
…te collection for in-map object storing v0.5. DANGEROWS! NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852"

This reverts commit 1d1b24f.
rsa added a commit that referenced this issue Sep 17, 2012
@rsa
use unordered_map instead of TypeUnorderedMapContainer template colle…
4cd6484 
…ction for in-map object storing v0.6. DANGEROUS!

- possible also not full stable (need make separate update queue for items)
NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Sep 20, 2012
@rsa
rewrite MapObjectsStore v0.7
0a77558 
- use unordered_map instead of TypeUnorderedMapContainer template collection
- full rewrite object update making system, make dependent update queue for players items
- correct Camera appending to not-in-world objects
- add Transport objects to current Map storing/updating system (currently by half-hack)
- simplify code
    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Sep 21, 2012
@rsa
rewrite MapObjectsStore v0.8
04f0a66 
  - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
  - revert some changes from versions 3-6 (need more work)
  - use unordered_map instead of TypeUnorderedMapContainer template collection
  - full rewrite object update making system, make dependent update queue for players items
  - correct Camera appending to not-in-world objects
  - add Transport objects to current Map storing/updating system (currently by half-hack)
  - simplify code
NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Sep 24, 2012
@rsa
rewrite MapObjectsStore v0.8.1
ac3a89e 
    - use LockedVector instead of std::list in Camera object.
    - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
    - revert some changes from versions 3-6 (need more work)
    - use unordered_map instead of TypeUnorderedMapContainer template collection
    - full rewrite object update making system, make dependent update queue for players items
    - correct Camera appending to not-in-world objects
    - add Transport objects to current Map storing/updating system (currently by half-hack)
    - simplify code
NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Oct 2, 2012
@rsa
rewrite MapObjectsStore v0.9
35f6258 
    - use LockedVector instead of std::list in Camera object.
    - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
    - revert some changes from versions 3-6 (need more work)
    - use unordered_map instead of TypeUnorderedMapContainer template collection
    - full rewrite object update making system, make dependent update queue for players items
    - correct Camera appending to not-in-world objects
    - add Transport objects to current Map storing/updating system (currently by half-hack)
    - simplify code
NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Oct 11, 2012
@rsa
rewrite MapObjectsStore v0.10
3b4756a 
  - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
  - use unordered_map instead of TypeUnorderedMapContainer template collection
  - full rewrite object update making system, make dependent update queue for players items
  - add Transport objects to current Map storing/updating system (currently by half-hack)
  - simplify code
    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Oct 30, 2012
@rsa
rewrite MapObjectsStore v0.11
52d88a7 
  - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
  - use unordered_map instead of TypeUnorderedMapContainer template collection
  - full rewrite object update making system, make dependent update queue for players items
  - add Transport objects to current Map storing/updating system (currently by half-hack)
  - simplify code
    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Nov 2, 2012
@rsa
rewrite MapObjectsStore v0.12
035725d 
  - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
  - use unordered_map instead of TypeUnorderedMapContainer template collection
  - full rewrite object update making system, make dependent update queue for players items
  - add Transport objects to current Map storing/updating system (currently by half-hack)
  - simplify code
  - use storing guids instead of pointers in Camera/Viewpoint subsystem for fit new object storing system

    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Nov 3, 2012
@rsa
rewrite MapObjectsStore v0.13
df1d944 
  - use GuidSet for make object-safe UpdateDataMapType (this fix at least pet action bar after mount)
  - use unordered_map instead of TypeUnorderedMapContainer template collection
  - full rewrite object update making system, make dependent update queue for players items
  - add Transport objects to current Map storing/updating system (currently by half-hack)
  - simplify code
  - use storing guids instead of pointers in Camera/Viewpoint subsystem for fit new object storing system
  - fix very old bug with Sentry totem (appears only now).

    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
rsa added a commit that referenced this issue Nov 12, 2012
@rsa
[mr2423] rewrite MapObjectsStore v0.13 - use GuidSet for make object-…
108a7dc 
…safe UpdateDataMapType (this fix at least pet action bar after mount) - use unordered_map instead of TypeUnorderedMapContainer template collection - full rewrite object update making system, make dependent update queue for players items - add Transport objects to current Map storing/updating system (currently by half-hack) - simplify code - use storing guids instead of pointers in Camera/Viewpoint subsystem for fit new object storing system - fix very old bug with Sentry totem (appears only now).

    NEED TEST and measurements CPU load and resource leaks! related to #1165, #1083, #852
mns added a commit that referenced this issue Mar 1, 2013
@mns
[mr2711] Fix broken unloading arena maps. #1083
fa02f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mns @rsa @RangerRU