Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual Layer Flipping #10

Open
wants to merge 40 commits into
base: miryoku
Choose a base branch
from
Open

Conversation

xervon
Copy link

@xervon xervon commented Nov 26, 2022

This change allows the user to flip individual layers.

To facilitate this, I

  • changed the parameter MIRYOKU_LAYERS to
    • accept values of the form FLIP_$LAYER (e.g. MIRYOKU_LAYERS=FLIP_SYM)
    • accept a list of values separated by commas
  • added a new parameter MIRYOKU_THUMBKEYS_LAYER, that
    • accepts values of the form $THUMBKEY=$LAYER (e.g. LO=MEDIA)
      • for now I've named the thumb keys by hand and relative position, though I'm open to changing that
        • (left outer) LO
        • (left middle) LM
        • (left inner) LI
        • (right inner) RI
        • (right middle) RM
        • (right outer) RO
    • accepts a list of values separated by commas

I've also added an additional parameter MIRYOKU_THUMBKEYS_KEYCODE that allows the user to rebind the thumb keys. This parameter accepts a comma-separated list of values of the form $THUMBKEY=$QMK_KEY_CODE.

At the same time, this change allows decoupling the flipping of layers from the flipping of layer change keys. If a user wishes to use the same hand for switching to a layer (to facilitate one-handed media control for example), this is now possible.

Further this also simplifies using the thumb keys in combos since all thumbkey bindings are now defined as MIRYOKU_THUMBKEY_$THUMBKEY for the Layer-Tap binding and MIRYOKU_THUMBKEY_$THUMBKEY_KC for the Tap binding.

Following an example configuration (custom_rules.mk)

MIRYOKU_LAYERS=FLIP_MEDIA
MIRYOKU_THUMBKEYS_LAYER=LO=MOUSE,LI=MEDIA
MIRYOKU_THUMBKEYS_KEYCODE=RM=KC_DEL,RO=KC_BSPC

This flips the media layer while keeping all other layers and the thumb keys in normal order. It also switches the bindings for the MEDIA and MOUSE layers and switches Backspace and Delete.

Individual commits can be found at https://github.com/manna-harbour/miryoku_qmk/commits/miryoku-20220227

- Add FUNDING.yml
- Update root readme
- Remove files from .github
- Add workflows
- Add custom_config.h and custom_rules.mk to workflows
- Override local custom_rules.mk and custom_config.h in workflows
- Add merge field to workflows
- Update BT keycodes on Media inner index:
  - Move OUT_AUTO to bottom row
- Move RGB_TOG in vi to pinkie column to match other TOG keycodes, and rotate row
- Supports adding and removing layers from custom_config.h
- Add "U_" prefix to layer names
- Add layer name strings
- Populate keymaps array from X macro
- Populate layers enum from X macro
- Move layers enum to manna-harbour_miryoku.h
- Rename miryoku_alternatives.h to miryoku_layer_alternatives.h
- Rename miryoku_layer.h to miryoku_layer_selection.h
- Remove miryoku_layer_names.h
- Add miryoku_layer_list.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants