Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code injection? #85

Open
kousu opened this issue Jan 14, 2018 · 0 comments
Open

code injection? #85

kousu opened this issue Jan 14, 2018 · 0 comments

Comments

@kousu
Copy link

kousu commented Jan 14, 2018

Have you thought through points where greg could be subject to code injection? I'm thinking about what happens if you combine placeholders (with values taken from remote files) with a custom downloadhandler. What happens if someone sets {title} = abc; rm -rf ~/*; ls?

I see you use subprocess for this, so I think that should protect against it, but I'm not 100% sure. And there could be other injection points in the code too. Just something to think about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant